Hi Paul, Paul Martin [2008-10-08 16:17 +0100]: > My response is to push the check to the end of the block. We're still going > to get people saying "why am I getting spammed by cron?" due to the error > messages.
Indeed, that makes even more sense. Thanks for looking into it! > --- logrotate-3.7.1.orig/config.c 2008-10-08 15:57:39.318679248 +0100 > +++ logrotate-3.7.1/config.c 2008-10-08 16:09:33.203414313 +0100 > @@ -968,7 +970,8 @@ > > message(MESS_ERROR, "%s:%d glob failed for %s\n", > configFile, lineNum, argv[argNum]); > - return 1; > + glob_failed = 1; > + continue; Since you write the message in the hunk below, I think you need to drop it here, otherwise you'd write it twice without missingok and still once with missingok. Otherwise the idea is much better than my hack, indeed. Thanks! Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
signature.asc
Description: Digital signature
