Neil asked me to send futher information about the bug fix, so here it is.

1) Way to reproduce: No idea what needs to be done to trigger this bug, I only 
know that after I installed keytouch log-out and system shutdown from KDE 
didn't work anymore. 

2) Killing keytouchd is one possibility to workaround this bug.

3) Once I figured out keytouchd was the reason for my shutdown problem, I 
searched a bit and came across the ubuntu bugreport. The upstream author 
there describes the cause of the problem:

https://bugs.launchpad.net/debian/+source/keytouch/+bug/186713/comments/53

4) So I went ahead and added this patch (as backport from new upstream 2.4.1) 
to the debian package and uploaded the new package, with *only* this 
additional patch to mentors.debian.net


#! /bin/sh /usr/share/dpatch/dpatch-run
## 25_XCloseDisplay.dpatch by <[EMAIL PROTECTED]>
##
## DP: Backport from 2.4.0, allow proper X-session shutdown

@DPATCH@
diff -urNad keytouch-2.3.2~/keytouchd/main.c keytouch-2.3.2/keytouchd/main.c
--- keytouch-2.3.2~/keytouchd/main.c    2008-08-20 22:15:57.000000000 +0200
+++ keytouch-2.3.2/keytouchd/main.c     2008-08-20 22:16:53.587173950 +0200
@@ -168,7 +168,7 @@
        XmlFree (user_preferences.browser);
        XmlFree (user_preferences.email_program);
        XmlFree (user_preferences.chat_program);
-       XCloseDisplay (display);
+       /* XCloseDisplay (display); This may prevent keytouchd from terminating 
*/
        
        exit (EXIT_SUCCESS);
 }


5) Before I uploaded the new package to mentors, I also checked several times, 
that this patch indeed fixes the problem.


6) Interdiff output

[EMAIL PROTECTED] keytouch>interdiff -z keytouch_2.3.2-2.diff.gz 
keytouch_2.3.2-2.1.diff.gz
diff -u keytouch-2.3.2/debian/patches/00list 
keytouch-2.3.2/debian/patches/00list    
--- keytouch-2.3.2/debian/patches/00list                                        
     
+++ keytouch-2.3.2/debian/patches/00list                                        
     
@@ -3,0 +4 @@                                                                   
     
+25_XCloseDisplay.dpatch                                                        
     
diff -u keytouch-2.3.2/debian/changelog keytouch-2.3.2/debian/changelog         
     
--- keytouch-2.3.2/debian/changelog                                             
     
+++ keytouch-2.3.2/debian/changelog                                             
     
@@ -1,3 +1,11 @@                                                                
     
+keytouch (2.3.2-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * fix xsession shutdown problem
+  * (closes: #487629)
+
+ -- Bernd Schubert <[EMAIL PROTECTED]>  Wed, 20 Aug 2008 22:24:27 +0200
+
 keytouch (2.3.2-2) unstable; urgency=low

   * Vcs-* fields no longer need XS- prefix.
only in patch2:
unchanged:
--- keytouch-2.3.2.orig/debian/patches/25_XCloseDisplay.dpatch
+++ keytouch-2.3.2/debian/patches/25_XCloseDisplay.dpatch
@@ -0,0 +1,18 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 25_XCloseDisplay.dpatch by <[EMAIL PROTECTED]>
+##
+## DP: Backport from 2.4.0, allow proper X-session shutdown
+
[EMAIL PROTECTED]@
+diff -urNad keytouch-2.3.2~/keytouchd/main.c keytouch-2.3.2/keytouchd/main.c
+--- keytouch-2.3.2~/keytouchd/main.c   2008-08-20 22:15:57.000000000 +0200
++++ keytouch-2.3.2/keytouchd/main.c    2008-08-20 22:16:53.587173950 +0200
+@@ -168,7 +168,7 @@
+       XmlFree (user_preferences.browser);
+       XmlFree (user_preferences.email_program);
+       XmlFree (user_preferences.chat_program);
+-      XCloseDisplay (display);
++      /* XCloseDisplay (display); This may prevent keytouchd from 
terminating */
+
+       exit (EXIT_SUCCESS);
+ }



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to