severity 494447 important
thanks
On Sun, Aug 10, 2008 at 07:22:22PM +0200, Julian Andres Klode wrote:
> > The error is a buildtime check for the size of ino_t. This is 32 bit on
> > all s390 types but the code expects it to be equal to the word size.
> Should I simply remove the check? I can't test it myself, because I have
> no access to s390 machines (and no knowledge about it).
No, it would break.
There are at least two ways to make it better:
- Always save 64bit. Something like fs/gfs2/ops_export.c but with
"if (sizeof(ino_t) == 8)" as guard.
- Use a structure. fs/xfs/linux-2.6/xfs_export.c
But you have to speak with upstream about that. The code of this export
function looks way to different to all other filesystems which makes me
believe that there are other problems.
Bastian
--
The sight of death frightens them [Earthers].
-- Kras the Klingon, "Friday's Child", stardate 3497.2
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
