Your message dated Mon, 28 Jul 2008 09:32:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#492686: fixed in consolekit 0.2.10-2
has caused the Debian Bug report #492686,
regarding consolekit: Crash on startup if /var/run/console/ does not exist
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
492686: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=492686
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: consolekit
Version: 0.2.10-1
Severity: grave
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu ubuntu-patch intrepid
Hi Michael,
thanks for 0.2.10-1, it is a great release. I just noticed a small bug
in the "clean /var/run/console/" patch, if the directory does not
exist at all, it crashes with:
$ sudo console-kit-daemon --debug --no-daemon
console-kit-daemon[6206]: DEBUG: Debugging enabled
console-kit-daemon[6206]: DEBUG: initializing console-kit-daemon 0.2.10
console-kit-daemon[6206]: DEBUG: Cleaning up /var/run/console
console-kit-daemon[6206]: GLib-WARNING: GError set over the top of a previous
GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before
it's set.
The overwriting error message was: Error opening directory '/var/run/console':
No such file or directory
Segmentation fault
I fixed the GError handling in attached patch, and also demoted
g_warning to g_debug, since it is not an error at all if
/var/run/console/ does not exist at startup (e. g. if you enabled
RAMRUN in /etc/default/rcS).
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
* 03-cleanup_console_tags.patch: Properly initialize GError to avoid daemon
crash if /var/run/console/ does not exist. Also, demote message about it
from warning to debug, since it is not an error condition at all.
--- consolekit-0.2.10/debian/patches/03-cleanup_console_tags.patch
+++ consolekit-0.2.10/debian/patches/03-cleanup_console_tags.patch
@@ -12,14 +12,14 @@
+delete_console_tags (void)
+{
+ GDir *dir;
-+ GError *error;
++ GError *error = NULL;
+ const gchar *name;
+
+ g_debug ("Cleaning up %s", CONSOLE_TAGS_DIR);
+
+ dir = g_dir_open (CONSOLE_TAGS_DIR, 0, &error);
+ if (dir == NULL) {
-+ g_warning ("Couldn't open directory %s: %s", CONSOLE_TAGS_DIR,
++ g_debug ("Couldn't open directory %s: %s", CONSOLE_TAGS_DIR,
+ error->message);
+ g_error_free (error);
+ return;
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: consolekit
Source-Version: 0.2.10-2
We believe that the bug you reported is fixed in the latest version of
consolekit, which is due to be installed in the Debian FTP archive:
consolekit_0.2.10-2.diff.gz
to pool/main/c/consolekit/consolekit_0.2.10-2.diff.gz
consolekit_0.2.10-2.dsc
to pool/main/c/consolekit/consolekit_0.2.10-2.dsc
consolekit_0.2.10-2_i386.deb
to pool/main/c/consolekit/consolekit_0.2.10-2_i386.deb
libck-connector-dev_0.2.10-2_i386.deb
to pool/main/c/consolekit/libck-connector-dev_0.2.10-2_i386.deb
libck-connector0_0.2.10-2_i386.deb
to pool/main/c/consolekit/libck-connector0_0.2.10-2_i386.deb
libpam-ck-connector_0.2.10-2_i386.deb
to pool/main/c/consolekit/libpam-ck-connector_0.2.10-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Biebl <[EMAIL PROTECTED]> (supplier of updated consolekit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 28 Jul 2008 11:09:28 +0200
Source: consolekit
Binary: consolekit libck-connector0 libck-connector-dev libpam-ck-connector
Architecture: source i386
Version: 0.2.10-2
Distribution: unstable
Urgency: high
Maintainer: Utopia Maintenance Team <[EMAIL PROTECTED]>
Changed-By: Michael Biebl <[EMAIL PROTECTED]>
Description:
consolekit - framework for defining and tracking users, sessions and seats
libck-connector-dev - ConsoleKit development files
libck-connector0 - ConsoleKit libraries
libpam-ck-connector - ConsoleKit PAM module
Closes: 492686
Changes:
consolekit (0.2.10-2) unstable; urgency=high
.
* debian/patches/03-cleanup_console_tags.patch
- Properly initialize GError to avoid daemon crash if /var/run/console/
does not exist. Also, demote message about it from warning to debug,
since it is not an error condition at all. (Closes: #492686)
Patch by Martin Pitt, thanks.
Checksums-Sha1:
879a96aa733f3225faa46d572b716185e2d31bcf 1484 consolekit_0.2.10-2.dsc
7945fdd838292d7eb85bb8b5024d38631dedecde 6970 consolekit_0.2.10-2.diff.gz
933fdd4c6ec5f0e8bfa3af0bb7b73c6e67b7afec 125570 consolekit_0.2.10-2_i386.deb
422ed619a6b4cc821b70ae575c126f6a56d7423f 40926
libck-connector0_0.2.10-2_i386.deb
73e7f037eeecdb62d2632899282e1205520162e6 48344
libck-connector-dev_0.2.10-2_i386.deb
bf1eb5cf50a07723364ff5c350e9cd5c267b79cd 41166
libpam-ck-connector_0.2.10-2_i386.deb
Checksums-Sha256:
c5583f904a09dd5cb1e6dc27702f71df0e900f267d5ffe2ed38abbdcfbda3d35 1484
consolekit_0.2.10-2.dsc
ee3be1776758a13d8f1a712884112b2e92a9946a25cfaa61425c6d875bbda9a7 6970
consolekit_0.2.10-2.diff.gz
42acdb2c27c4ae0ac58f9c82e270dca741b10df4360e0b39e0a5278c06bf32e4 125570
consolekit_0.2.10-2_i386.deb
b57ec66c0a54f1e5adb383901164ca3f50513b481e1b8d430d682f53544ae9fe 40926
libck-connector0_0.2.10-2_i386.deb
938f216fac1552ed09a27a5894b24af8f6e71613a71618d857cbcfc9767b5285 48344
libck-connector-dev_0.2.10-2_i386.deb
7deaca287032c95a41ee90ad50354f1e2a2bcad56cc114a7455fe0a04ab6046a 41166
libpam-ck-connector_0.2.10-2_i386.deb
Files:
4579a460962da2ae707a7b5406d4a7e7 1484 admin optional consolekit_0.2.10-2.dsc
0d84f32c5104334031431125c55f352a 6970 admin optional
consolekit_0.2.10-2.diff.gz
84e3e655d32dd0b6237bcf75a634ad4a 125570 admin optional
consolekit_0.2.10-2_i386.deb
ede33124bf3936a442fcc5d4c7d396e8 40926 libs optional
libck-connector0_0.2.10-2_i386.deb
81a2ba04c96edf18280fba61e7ffbf8d 48344 libdevel optional
libck-connector-dev_0.2.10-2_i386.deb
6511dc3dbfb7bd8879b0ac49ae66d6a0 41166 admin optional
libpam-ck-connector_0.2.10-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkiNjpUACgkQh7PER70FhVSe9QCeP65aqTMN8T6PfmAW3lo0+yjE
HdQAn3BgTLPgrMcCC6czg5fcDaucar03
=z22f
-----END PGP SIGNATURE-----
--- End Message ---
