Package: skytools
Version: 2.1.6-1
Severity: serious
Justification: unfinished packaging :(

Few immediate problems with this package. For starters, the
changelog is just no good. 

  
http://www.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html#s-bpp-debian-changelog


Second, it is NOT ok to just dump a bunch of overrides for lintian
warnigs and errors to make them go away. What seem to be the main
binaries have no manpages. At least remove the lintian overrides. If
there is any documentation in /usr/share/doc/skytools but since there
isn't, then add some manpages. It is easy. You can just make them from
templates. Do that at least for the main binaries.


Finally, the package descriptions are just not up to par. Please
correct this. For example, a description may read,

Description: Skytools modules for PostgreSQL database
 Additional PostgreSQL included for use with skytools include,
 .
 * txid - 8-byte transaction id's
 * logtriga - Trigger function to log change in SQL format
 * logutriga - Trigger function to log change in urlencoded format
 * londiste - Database parts of replication engine
 * pgq - Generic queue in database


Of course my description is not exactly perfect either, but things
to remember is 

  * format lists by prepending them with * character
  * short description should indicate the content of the package
  * the list item descriptions are too generic. For example, what is
    the  "Generic queue in database" or "Database parts of replication
    engine"? Are these even usable separately from the skytools package?

The skytools package short description may be improved by
removing the "Python parts" as it is not needed. Also, formating the
list properly would help as well as filling in the blanks (I have no
idea what the package does from description)

Description: Skype database tools
 Skytools are database utilities used by Skype for <blah> (not sure
 what it actually does)
 .
 * londiste - replication   (of what?)
 * pgqadm - generic event queue (??))
 * walmgr - failover server scripts (what server? Skype server?)

Again, the description is not written clearly.


If this was just description, this would be a minor bug but
considering this package is so small, and there is so many mistakes
and unfinished packaging work, the package really needs some work
before it is allowed to Lenny.

- Adam


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (5, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.25-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to