Hello, On Mon, Apr 14, 2008 at 12:52:32PM +0200, Julien Cristau wrote: > On Mon, Apr 14, 2008 at 12:36:24 +0200, Sylvain Le Gall wrote: > > > I have already solved this bug for package unison2.13.16 (should be in > > NEW). > > > > The real problem is that CFLAGS is set and means Compilations FLAGS for > > the unison makefile. So it uses this flags for the OCaml compiler, which > > doesn't work. > > That's utterly broken. CFLAGS is meant as flags for the C compiler. >
unison2.13.16 is legacy. I am preparing a package with the newer version (2.27). Maybe this bug won't affect newer version (2.27). Fixing this kind of legacy package by overriding this variable is not that awful. If the bug appear in newer version, i will patch and submit the bug upstream. > > I will apply a more "smart" patching to solve this issue (add the good > > option to CFLAGS replacing the -O2 by some compatbile option for ocaml). > > Ewww. Are you going to do the same for every possible flag? > Either fixing the makefile to use another variable or unsetting CFLAGS > in debian/rules would be saner IMO. > That is what i am doing now (unsetting CFLAGS in debian/rules -- when calling "make all CFLAGS="). Following your recommendation, i will stay with my first solution... Which give me less work ;-) > > (this mail is for the record, since it is a mass bug filling, no one > > will read it) > > > Not true. > Great i was untrue... This give me the occasion to talk about this fix ;-) Regards Sylvain Le Gall -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
