Your message dated Sun, 29 May 2005 20:02:47 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#310936: fixed in oregano 0.40.0-5
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 27 May 2005 01:44:54 +0000
>From [EMAIL PROTECTED] Thu May 26 18:44:53 2005
Return-path: <[EMAIL PROTECTED]>
Received: from adsl-66-127-195-58.dsl.snfc21.pacbell.net (panda.mostang.com) 
[66.127.195.58] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DbTu9-0008Cv-00; Thu, 26 May 2005 18:44:53 -0700
Received: by panda.mostang.com (Postfix, from userid 199)
        id 87FE3D403B; Thu, 26 May 2005 18:44:52 -0700 (PDT)
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Subject: oregano fixes for ia64
X-URL: http://www.mostang.com/~davidm/
Reply-To: [EMAIL PROTECTED]
Message-Id: <[EMAIL PROTECTED]>
Date: Thu, 26 May 2005 18:44:52 -0700 (PDT)
From: [EMAIL PROTECTED] (David Mosberger-Tang)
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_01,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 


Package: oregano
Version: 0.40.0-3
Severity: serious
Tags: patch

Oregano defines GNOME_DISABLE_DEPRECATED which has the effect that
gnome_menu_item_new() does NOT get declared.  As a result, the
function gets implicitly defined to return an "int", which is a
problem on 64-bit architectures since the pointer cannot fit in an
int.  In particular, this is guaranteed to cause a SIGSEGV on ia64
since the top 32 bits would get truncated to zero.

Second, node_store_get_type() attempted to use guint to store a GTK
type when GType is needed.  This caused an immediate segfault on ia64
at startup.

Third, part-property.c passed a pointer to an unitialized size_t-typed
variable to get_macro_name(), which was expecting only an int pointer.
Thus, the top 32-bits remained unitialized and on ia64 this caused a
crash when attempting to insert any part.

Patch below fixes all three problems.  Please apply (and forward to
upstream if appropriate).

Thanks!

        --david

diff -urN oregano-0.40.0/src/Makefile.am oregano-0.40.0-davidm/src/Makefile.am
--- oregano-0.40.0/src/Makefile.am      2005-05-26 18:23:27.000000000 -0700
+++ oregano-0.40.0-davidm/src/Makefile.am       2005-05-26 18:05:19.000000000 
-0700
@@ -15,8 +15,8 @@
        -DDATADIR=\""$(datadir)"\" \
        $(OREGANO_CFLAGS)       \
   -DGDK_DISABLE_DEPRECATED=1 \
-  -DGLIB_DISABLE_DEPRECATED=1 \
-  -DGNOME_DISABLE_DEPRECATED=1
+  -DGLIB_DISABLE_DEPRECATED=1
+#  -DGNOME_DISABLE_DEPRECATED=1
 #  -DGTK_DISABLE_DEPRECATED=1 
 
 bin_SCRIPTS = oregano_parser
diff -urN oregano-0.40.0/src/Makefile.in oregano-0.40.0-davidm/src/Makefile.in
--- oregano-0.40.0/src/Makefile.in      2005-05-26 18:23:27.000000000 -0700
+++ oregano-0.40.0-davidm/src/Makefile.in       2005-05-26 18:06:47.000000000 
-0700
@@ -137,7 +137,7 @@
 
 oreganodir = $(datadir)/oregano
 
-INCLUDES =     -DGNOMELOCALEDIR=\""$(datadir)/locale"\"                
-I$(includedir) $(GNOME_INCLUDEDIR)               
-DOREGANO_GLADEDIR=\""$(oreganodir)/glade"\"    
-DOREGANO_LIBRARYDIR=\""$(oreganodir)/libraries"\"    
-DOREGANO_MODELDIR=\""$(oreganodir)/models"\"   -DDATADIR=\""$(datadir)"\"      
$(OREGANO_CFLAGS)         -DGDK_DISABLE_DEPRECATED=1   
-DGLIB_DISABLE_DEPRECATED=1   -DGNOME_DISABLE_DEPRECATED=1
+INCLUDES =     -DGNOMELOCALEDIR=\""$(datadir)/locale"\"                
-I$(includedir) $(GNOME_INCLUDEDIR)               
-DOREGANO_GLADEDIR=\""$(oreganodir)/glade"\"    
-DOREGANO_LIBRARYDIR=\""$(oreganodir)/libraries"\"    
-DOREGANO_MODELDIR=\""$(oreganodir)/models"\"   -DDATADIR=\""$(datadir)"\"      
$(OREGANO_CFLAGS)         -DGDK_DISABLE_DEPRECATED=1   
-DGLIB_DISABLE_DEPRECATED=1
 
 #  -DGTK_DISABLE_DEPRECATED=1 
 
diff -urN oregano-0.40.0/src/node-store.c oregano-0.40.0-davidm/src/node-store.c
--- oregano-0.40.0/src/node-store.c     2004-10-11 12:04:27.000000000 -0700
+++ oregano-0.40.0-davidm/src/node-store.c      2005-05-26 18:12:45.000000000 
-0700
@@ -88,7 +88,7 @@
 GType
 node_store_get_type (void)
 {
-       static guint node_store_type = 0;
+       static GType node_store_type = 0;
 
        if (!node_store_type) {
                static const GTypeInfo node_store_info = {
diff -urN oregano-0.40.0/src/part-property.c 
oregano-0.40.0-davidm/src/part-property.c
--- oregano-0.40.0/src/part-property.c  2004-10-10 11:20:28.000000000 -0700
+++ oregano-0.40.0-davidm/src/part-property.c   2005-05-26 18:17:38.000000000 
-0700
@@ -42,7 +42,7 @@
  * @return the name of a macro variable
  */
 static char *get_macro_name (const char *str, char **cls1,
-       char **cls2, int *sz)
+       char **cls2, size_t *sz)
 {
        char tmp[512], separators[] = { ",.;/|()" };
        char *id;
@@ -105,7 +105,7 @@
                }
        }
 
-       *sz = (int) (q - str);
+       *sz = (q - str);
        return id;
 
  error:

---------------------------------------
Received: (at 310936-close) by bugs.debian.org; 30 May 2005 00:08:25 +0000
>From [EMAIL PROTECTED] Sun May 29 17:08:25 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DcXpR-0007QQ-00; Sun, 29 May 2005 17:08:25 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
        id 1DcXjz-0008VB-00; Sun, 29 May 2005 20:02:47 -0400
From: Maximiliano Curia <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#310936: fixed in oregano 0.40.0-5
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sun, 29 May 2005 20:02:47 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: oregano
Source-Version: 0.40.0-5

We believe that the bug you reported is fixed in the latest version of
oregano, which is due to be installed in the Debian FTP archive:

oregano_0.40.0-5.diff.gz
  to pool/main/o/oregano/oregano_0.40.0-5.diff.gz
oregano_0.40.0-5.dsc
  to pool/main/o/oregano/oregano_0.40.0-5.dsc
oregano_0.40.0-5_i386.deb
  to pool/main/o/oregano/oregano_0.40.0-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Maximiliano Curia <[EMAIL PROTECTED]> (supplier of updated oregano package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 29 May 2005 14:23:24 -0300
Source: oregano
Binary: oregano
Architecture: source i386
Version: 0.40.0-5
Distribution: unstable
Urgency: high
Maintainer: Jordi Mallach <[EMAIL PROTECTED]>
Changed-By: Maximiliano Curia <[EMAIL PROTECTED]>
Description: 
 oregano    - tool for schematical capture of electronic circuits
Closes: 310936
Changes: 
 oregano (0.40.0-5) unstable; urgency=high
 .
   * Fixes segfaults on ia64 - thanks to David
     Mosberger-Tang <[EMAIL PROTECTED]> (Closes: #310936).
Files: 
 651de7883637837665b3b18a14f92dc1 847 electronics optional oregano_0.40.0-5.dsc
 14abd4b426d44b27fe222c7271c9b5d7 35078 electronics optional 
oregano_0.40.0-5.diff.gz
 1ec4013290502c8eb59b5931918b5dbf 619914 electronics optional 
oregano_0.40.0-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCmlTrJYSUupF6Il4RAuXiAJ9cQTOjRYsU5HAyns5xcGu8tZzZSACfRuuV
ZfohGPiGHYAOdsYFkAMHXHU=
=6RsL
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to