Your message dated Fri, 22 Feb 2008 23:47:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#446104: fixed in nstx 1.1-beta6-4.1
has caused the Debian Bug report #446104,
regarding nstxd leaks like a sieve
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
446104: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=446104
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: nstx
Version: 1.1-beta6
Severity: Grave
tags: patch
nstxd leaks like a sieve. As it is intended as a long running service
this makes it mostly unusable (and has caused a server of mine to lockup
and lose unrelated data).
This patch appears to ccorrect the problem in my case, and twiddles a
few trivial things. I have not checked for leaks in nstxcd.
Matthew W. S. Bell
diff -ruN nstx-1.1-beta6/nstxd.c nstx-1.1-beta6.new/nstxd.c
--- nstx-1.1-beta6/nstxd.c 2007-10-10 15:14:39.000000000 +0100
+++ nstx-1.1-beta6.new/nstxd.c 2007-10-10 00:58:48.000000000 +0100
@@ -179,7 +179,8 @@
void nstx_getpacket (void) {
int len, link;
- const char *name, *buf, *data;
+ const char *name, *inbuf, *data;
+ char *outbuf = NULL;
struct nstxmsg *msg;
struct nstxqueue *qitem;
struct dnspkt *pkt;
@@ -198,9 +199,9 @@
name);
queueitem(pkt->id, name, &msg->peer);
if ((data = dns_fqdn2data(name)) &&
- (buf = nstx_decode((unsigned char*)data, &len)))
+ (inbuf = nstx_decode((unsigned char*)data, &len)))
{
- nstx_handlepacket(buf, len, &sendtun);
+ nstx_handlepacket(inbuf, len, &sendtun);
}
}
dns_free(pkt);
@@ -218,10 +219,12 @@
dns_settype(pkt, DNS_RESPONSE);
link = dns_addquery(pkt, qitem->name);
len = dns_getfreespace(pkt, DNS_RESPONSE);
- buf = dequeue_senditem(&len);
- dns_addanswer(pkt, buf, len, link);
- buf = (char*)dns_constructpacket(pkt, &len);
- sendns(buf, len, &qitem->peer);
+ outbuf = dequeue_senditem(&len);
+ dns_addanswer(pkt, outbuf, len, link);
+ outbuf = (char*)dns_constructpacket(pkt, &len);
+ sendns(outbuf, len, &qitem->peer);
+ free(outbuf);
+ free(qitem);
}
timeoutqueue(do_timeout);
}
diff -ruN nstx-1.1-beta6/nstx_dns.c nstx-1.1-beta6.new/nstx_dns.c
--- nstx-1.1-beta6/nstx_dns.c 2007-10-10 15:14:39.000000000 +0100
+++ nstx-1.1-beta6.new/nstx_dns.c 2007-10-09 23:24:09.000000000 +0100
@@ -450,7 +450,7 @@
ptr += list->len;
}
*l = len;
- dns_free (pkt);
+ dns_free(pkt);
return buf;
}
@@ -505,7 +505,7 @@
{
if (remain < 12)
{
- syslog(LOG_ERR, "dns_extractpkt: too less bytes in an\n");
+ syslog(LOG_ERR, "dns_extractpkt: too few bytes in an\n");
free(offsets);
dns_free(pkt);
return NULL;
@@ -530,6 +530,7 @@
{
syslog(LOG_ERR, "dns_extractpkt: record too long in an (%d->%d)\n",
remain, rrp->len);
+ free(offsets);
dns_free(pkt);
return NULL;
}
@@ -538,6 +539,7 @@
ptr += rrp->len;
remain -= rrp->len;
}
+ free(offsets);
return pkt;
}
diff -ruN nstx-1.1-beta6/nstx_queue.c nstx-1.1-beta6.new/nstx_queue.c
--- nstx-1.1-beta6/nstx_queue.c 2004-06-27 22:43:34.000000000 +0100
+++ nstx-1.1-beta6.new/nstx_queue.c 2007-10-10 00:35:22.000000000 +0100
@@ -59,8 +59,6 @@
if (!qhead)
return NULL;
- if (tmp)
- free(tmp);
if ((id < 0) || (qhead->id == id))
{
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---
Source: nstx
Source-Version: 1.1-beta6-4.1
We believe that the bug you reported is fixed in the latest version of
nstx, which is due to be installed in the Debian FTP archive:
nstx_1.1-beta6-4.1.diff.gz
to pool/main/n/nstx/nstx_1.1-beta6-4.1.diff.gz
nstx_1.1-beta6-4.1.dsc
to pool/main/n/nstx/nstx_1.1-beta6-4.1.dsc
nstx_1.1-beta6-4.1_amd64.deb
to pool/main/n/nstx/nstx_1.1-beta6-4.1_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Juan Angulo Moreno <[EMAIL PROTECTED]> (supplier of updated nstx package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 22 Feb 2008 15:15:35 -0430
Source: nstx
Binary: nstx
Architecture: source amd64
Version: 1.1-beta6-4.1
Distribution: unstable
Urgency: low
Maintainer: Matthew Garrett <[EMAIL PROTECTED]>
Changed-By: Juan Angulo Moreno <[EMAIL PROTECTED]>
Description:
nstx - Tunnel IP over DNS
Closes: 446104
Changes:
nstx (1.1-beta6-4.1) unstable; urgency=low
.
* Non-maintainer upload.
* Apply patch to fix: nstxd leaks like a sieve. (Closes: #446104)
Files:
9bc8307a32c9c68941f0e642eb8eabe6 577 net optional nstx_1.1-beta6-4.1.dsc
2517ac0a416345c2de2581f9d804c6e9 8726 net optional nstx_1.1-beta6-4.1.diff.gz
cb61b841b9e6ae1ee24efeb77418f8c6 24956 net optional
nstx_1.1-beta6-4.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFHv1tIgY5NIXPNpFURAoxCAJ9rzd1xW3MIWLe9OwRYDGcEBaOxGACfSZsk
EJlD1nz8pEyEq313VLTxlIk=
=w+HY
-----END PGP SIGNATURE-----
--- End Message ---
