I'm pretty sure we did send them upstream ... On 08/02/2008, Moritz Muehlenhoff <[EMAIL PROTECTED]> wrote: > On Thu, Feb 07, 2008 at 09:58:09AM +0100, Isaac Clerencia wrote: > > On Feb 7, 2008 9:20 AM, Marc 'HE' Brockschmidt <[EMAIL PROTECTED]> wrote: > > > Heya, > > > > > > The bug about the embedded copy of phpmailer in moodle has been open for > > > ages now without any activity. Isaac, you said you couldn't use the > > > Debian package (at that time): Is that still true? Would it be possible > > > to adjust libphp-phpmailer to your needs? > > Well, I am basically MIA at the time, so I am not too responsive and > > don't have the > > time to check again, but as far as I know nothing has changed and Moodle > > still > > requires a modified phpmailer. > > Isaac, please search for a co-maintainer. Moodle has regular security issues > and needs to be maintained by someone who can test update etc. > > Wrt the phpmailer copy: > The differences between Moodle's version of phpmailer and the lib version in > Debian are minimal, from a cursory check it's: > > 1. Adding another MSD ID for threading > 2. A multibyte encoding fix > > $ diff -waur ./lib/phpmailer/class.phpmailer.php > ../libphp-phpmailer-1.73/class.phpmailer.php | diffstat > class.phpmailer.php | 69 > ++-------------------------------------------------- > 1 file changed, 3 insertions(+), 66 deletions(-) > > This could be resolved upstream, e.g. by sending the bugfixes to phpmailer > upstream. I don't see why we should apply lower standards for PHP applications > than we do for regular C-based applications. > > Since there's still plenty of time left before Lenny I'd recommend to leave > this > bug open for now. > > Cheers, > Moritz > > > >
-- /// Moodle - open-source software for collaborative learning /// /// Free software, community, information: http://moodle.org /// Commercial support and other services: http://moodle.com -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
