Your message dated Sun, 03 Feb 2008 20:47:28 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#462966: fixed in pdns 2.9.21-5
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: pdns
Version: 2.9.21-4
Severity: serious
Hi guys,
pdns now fails to build in unstable and testing, because libldap2-dev has
been updated to the openldap 2.4 version and several functions are
deprecated:
[...]
alpha-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../.. -pthread -D_GNU_SOURCE
-Wall -g -O2 -Wall -O2 -MT powerldap.lo -MD -MP -MF .deps/powerldap.Tpo -c
powerldap.cc -fPIC -DPIC -o .libs/powerldap.o
powerldap.cc: In constructor 'PowerLDAP::PowerLDAP(const std::string&,
uint16_t, bool)':
powerldap.cc:12: error: 'ldap_init' was not declared in this scope
powerldap.cc:19: error: 'ldap_unbind' was not declared in this scope
powerldap.cc:29: error: 'ldap_unbind' was not declared in this scope
powerldap.cc: In destructor 'PowerLDAP::~PowerLDAP()':
powerldap.cc:38: error: 'ldap_unbind' was not declared in this scope
powerldap.cc: In member function 'void PowerLDAP::simpleBind(const
std::string&, const std::string&)':
powerldap.cc:63: error: 'ldap_simple_bind_s' was not declared in this scope
powerldap.cc: In member function 'int PowerLDAP::search(const std::string&,
int, const std::string&, const char**)':
powerldap.cc:73: error: 'ldap_search' was not declared in this scope
make[3]: *** [powerldap.lo] Error 1
make[3]: Leaving directory `/build/buildd/pdns-2.9.21/modules/ldapbackend'
make[2]: *** [install-recursive] Error 1
[...]
A full build log is available at
<http://buildd.debian.org/fetch.cgi?pkg=pdns&arch=alpha&ver=2.9.21-4%2Bb1&stamp=1201322902&file=log&as=raw>.
According to ldap.h, these functions are each deprecated. The attached
patch updates the code so that it builds with openldap 2.4; I haven't
verified that it runs correctly. Alternatively, you can build with
-DLDAP_DEPRECATED to get the prototypes for these deprecated functions.
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[EMAIL PROTECTED] [EMAIL PROTECTED]
diff -u pdns-2.9.21/debian/changelog pdns-2.9.21/debian/changelog
--- pdns-2.9.21/debian/changelog
+++ pdns-2.9.21/debian/changelog
@@ -1,3 +1,10 @@
+pdns (2.9.21-4.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Patch to build with openldap 2.4.
+
+ -- Steve Langasek <[EMAIL PROTECTED]> Mon, 28 Jan 2008 00:11:44 +0000
+
pdns (2.9.21-4) unstable; urgency=low
* New portuguese translation included (closes: #444219).
only in patch2:
unchanged:
--- pdns-2.9.21.orig/modules/ldapbackend/powerldap.cc
+++ pdns-2.9.21/modules/ldapbackend/powerldap.cc
@@ -9,16 +9,7 @@
if( ldap_initialize( &d_ld, hosts.c_str() ) != LDAP_SUCCESS )
{
- if( ( d_ld = ldap_init( hosts.c_str(), port ) ) == NULL )
- {
- throw LDAPException( "Error initializing LDAP connection: " + string( strerror( errno ) ) );
- }
-
- if( tls && ldap_start_tls_s( d_ld, NULL, NULL ) != LDAP_SUCCESS )
- {
- ldap_unbind( d_ld );
- throw( LDAPException( "Couldn't perform STARTTLS" ) );
- }
+ throw LDAPException( "Error initializing LDAP connection: " + string( strerror( errno ) ) );
}
if( ldap_set_option( d_ld, LDAP_OPT_PROTOCOL_VERSION, &protocol ) != LDAP_OPT_SUCCESS )
@@ -26,7 +17,7 @@
protocol = LDAP_VERSION2;
if( ldap_set_option( d_ld, LDAP_OPT_PROTOCOL_VERSION, &protocol ) != LDAP_OPT_SUCCESS )
{
- ldap_unbind( d_ld );
+ ldap_unbind_ext( d_ld, NULL, NULL );
throw LDAPException( "Couldn't set protocol version to LDAPv3 or LDAPv2" );
}
}
@@ -35,7 +26,7 @@
PowerLDAP::~PowerLDAP()
{
- ldap_unbind( d_ld );
+ ldap_unbind_ext( d_ld, NULL, NULL );
}
@@ -60,7 +51,10 @@
void PowerLDAP::simpleBind( const string& ldapbinddn, const string& ldapsecret )
{
int err;
- if( ( err = ldap_simple_bind_s( d_ld, ldapbinddn.c_str(), ldapsecret.c_str() ) ) != LDAP_SUCCESS )
+ struct berval passwd;
+ passwd.bv_val = (char *)ldapsecret.c_str();
+ passwd.bv_len = strlen(passwd.bv_val);
+ if( ( err = ldap_sasl_bind_s( d_ld, ldapbinddn.c_str(), LDAP_SASL_SIMPLE, &passwd, NULL, NULL, NULL ) ) != LDAP_SUCCESS )
{
throw LDAPException( "Failed to bind to LDAP server: " + getError( err ) );
}
@@ -69,10 +63,10 @@
int PowerLDAP::search( const string& base, int scope, const string& filter, const char** attr )
{
- int msgid;
- if( ( msgid = ldap_search( d_ld, base.c_str(), scope, filter.c_str(), const_cast<char**> (attr), 0 ) ) == -1 )
+ int msgid, rc;
+ if( ( rc = ldap_search_ext( d_ld, base.c_str(), scope, filter.c_str(), const_cast<char**> (attr), 0, NULL, NULL, NULL, LDAP_NO_LIMIT, &msgid ) ) != LDAP_SUCCESS )
{
- throw LDAPException( "Starting LDAP search: " + getError() );
+ throw LDAPException( "Starting LDAP search: " + getError(rc) );
}
return msgid;
--- End Message ---
--- Begin Message ---
Source: pdns
Source-Version: 2.9.21-5
We believe that the bug you reported is fixed in the latest version of
pdns, which is due to be installed in the Debian FTP archive:
pdns-backend-geo_2.9.21-5_i386.deb
to pool/main/p/pdns/pdns-backend-geo_2.9.21-5_i386.deb
pdns-backend-ldap_2.9.21-5_i386.deb
to pool/main/p/pdns/pdns-backend-ldap_2.9.21-5_i386.deb
pdns-backend-mysql_2.9.21-5_i386.deb
to pool/main/p/pdns/pdns-backend-mysql_2.9.21-5_i386.deb
pdns-backend-pgsql_2.9.21-5_i386.deb
to pool/main/p/pdns/pdns-backend-pgsql_2.9.21-5_i386.deb
pdns-backend-pipe_2.9.21-5_i386.deb
to pool/main/p/pdns/pdns-backend-pipe_2.9.21-5_i386.deb
pdns-backend-sqlite3_2.9.21-5_i386.deb
to pool/main/p/pdns/pdns-backend-sqlite3_2.9.21-5_i386.deb
pdns-backend-sqlite_2.9.21-5_i386.deb
to pool/main/p/pdns/pdns-backend-sqlite_2.9.21-5_i386.deb
pdns-doc_2.9.21-5_all.deb
to pool/main/p/pdns/pdns-doc_2.9.21-5_all.deb
pdns-server_2.9.21-5_i386.deb
to pool/main/p/pdns/pdns-server_2.9.21-5_i386.deb
pdns_2.9.21-5.diff.gz
to pool/main/p/pdns/pdns_2.9.21-5.diff.gz
pdns_2.9.21-5.dsc
to pool/main/p/pdns/pdns_2.9.21-5.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Matthijs Mohlmann <[EMAIL PROTECTED]> (supplier of updated pdns package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 03 Feb 2008 20:57:51 +0100
Source: pdns
Binary: pdns-server pdns-doc pdns-backend-pipe pdns-backend-ldap
pdns-backend-geo pdns-backend-mysql pdns-backend-pgsql pdns-backend-sqlite
pdns-backend-sqlite3
Architecture: source i386 all
Version: 2.9.21-5
Distribution: unstable
Urgency: low
Maintainer: [EMAIL PROTECTED]
Changed-By: Matthijs Mohlmann <[EMAIL PROTECTED]>
Description:
pdns-backend-geo - geo backend for PowerDNS
pdns-backend-ldap - LDAP backend for PowerDNS
pdns-backend-mysql - generic mysql backend for PowerDNS
pdns-backend-pgsql - generic PostgreSQL backend for PowerDNS
pdns-backend-pipe - pipe/coprocess backend for PowerDNS
pdns-backend-sqlite - sqlite backend for PowerDNS
pdns-backend-sqlite3 - sqlite backend for PowerDNS
pdns-doc - PowerDNS manual
pdns-server - extremely powerful and versatile nameserver
Closes: 456073 462858 462966
Changes:
pdns (2.9.21-5) unstable; urgency=low
.
* Fix ignoring buid errors. (Closes: #462858)
* Patch from Steve to fix build with OpenLDAP 2.4. (Closes: #462966)
- Changed patch a bit to convert host, port and tls option to a ldapuri.
* Update Standards-Version to 3.7.3.
* Added gcc 4.3 fixes (Closes: #456073)
Files:
904fdb74b4b78c8e99ed21afd1e8c484 1157 net extra pdns_2.9.21-5.dsc
007c7b4ae879401c8dc7bf8f036a308c 34689 net extra pdns_2.9.21-5.diff.gz
1b70cc52ada4731ab050f1a65fefc40f 733220 net extra pdns-server_2.9.21-5_i386.deb
284e1467e677c806d2a4f83934d877f2 77344 net extra
pdns-backend-pipe_2.9.21-5_i386.deb
71021d5db6407a0d66808c7c4f9b0cf3 269722 net extra
pdns-backend-ldap_2.9.21-5_i386.deb
e62cdb7408d95ee859729ae8697034f9 101350 net extra
pdns-backend-geo_2.9.21-5_i386.deb
ab104eaa3200ddff6b7b21ee797ff030 66136 net extra
pdns-backend-mysql_2.9.21-5_i386.deb
936f7e4646b32904c988dbfe20853940 69662 net extra
pdns-backend-pgsql_2.9.21-5_i386.deb
11d8152bc360bf40b03026aef6b95c60 63636 net extra
pdns-backend-sqlite_2.9.21-5_i386.deb
b58642579e93ae5c0286b843f3ebe278 62974 net extra
pdns-backend-sqlite3_2.9.21-5_i386.deb
375c504242c967961beb99f706bc1c40 174426 doc extra pdns-doc_2.9.21-5_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFHpiM22n1ROIkXqbARAnV6AJ9H4tTVgm7iWLYq62denzJKW4/vOQCffhE4
uiXP8WoMfdootoR78NvDak8=
=RZhS
-----END PGP SIGNATURE-----
--- End Message ---
