diff -u awardeco-0.2/debian/changelog awardeco-0.2/debian/changelog
--- awardeco-0.2/debian/changelog
+++ awardeco-0.2/debian/changelog
@@ -1,3 +1,11 @@
+awardeco (0.2-2.1) unstable; urgency=low
+
+  * Non-Maintainer Upload at BSP in Zurich: fix rc bug
+  * Use the C99 bit length integer, to be safe on various archs

Please add "(Closes: #438385)" here. Also, please end all changelog
lines with a full stop and start sentences with capital letters for
consistency.

oops. Ok. the first was a cut-copy error trying cdbs-edit-patch
(nice tools!). Never realized about cosmetic consistency, I'll fix
also that.

--- awardeco-0.2.orig/debian/patches/30_fixeduint.patch
+++ awardeco-0.2/debian/patches/30_fixeduint.patch
@@ -0,0 +1,17 @@
+diff -Nur awardeco-0.2/src/awardeco.h awardeco-0.2.new/src/awardeco.h
+--- awardeco-0.2/src/awardeco.h        2006-08-05 11:38:03.000000000 +0200
++++ awardeco-0.2.new/src/awardeco.h    2008-01-16 08:12:10.000000000 +0100
+@@ -10,10 +10,11 @@
+ #define AWARDECO_H 1
+ + #include <stdio.h>
++#include      <stdint.h>
+ + typedef unsigned char byte;

Maybe make this uint8_t then, too, for consistency? Yes, it's more
cosmetical, but still.

yes. This change doesn't harm:  in C, char is a byte and in POSIX,
char is 8 bit. So I take a smaller NMU.  But reading the code it
seems ok to do this conversion.

I've some other minor stylistic C correction, i.e. "0xFFFFFFFF;"
is wrong, it should have a "u" postfix. (and "ul" if we care
about real C, but anyway POSIX int is 32-bit or more.),
but for this I think I (or you) should contact upstream author.

ciao
        cate



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to