Your message dated Fri, 07 Dec 2007 18:47:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#452963: fixed in kvm 55+dfsg-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: kvm
Version: 53-1
Severity: serious
Justification: Policy 2.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


The orig.tar.gz you ship contains around 1 MB of various blobs. This
violates the LGPL under which most of them are released (you're shipping
binaries without accompanying source code) and it's also in violation of
the dfsg.

I've revived your old get-orig-source target from debian/rules and
extended it to remove the additional violating files, and also adding a
work around to make qemu's build system happy (patch attached, mostly
taken from qemu) and adding the proper dependencies to the kvm binary
package (bochsbios-qemu (new package, patch sent to Debian's bochs
maintainer), and vgabios) and putting symlinks in place, just like qemu
does it.

- -- System Information:
Debian Release: lenny/sid
  APT prefers hardy
  APT policy: (500, 'hardy')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.22-14-generic (SMP w/2 CPU cores)
Locale: LANG=da_DK.UTF-8, LC_CTYPE=da_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHSqw6onjfXui9pOMRAkJVAJ4nyZt02MOK0e+JBfC2R+XF161b1ACgm7RQ
q9TVJguQSSkkTDPQgt/hsCc=
=2UhR
-----END PGP SIGNATURE-----
diff -urNw ../debian/kvm-53/debian/links debian/links
--- ../debian/kvm-53/debian/links       1970-01-01 01:00:00.000000000 +0100
+++ debian/links        2007-11-26 10:30:24.992510362 +0100
@@ -0,0 +1,3 @@
+usr/share/bochs/BIOS-bochs-latest-qemu usr/share/kvm/bios.bin
+usr/share/vgabios/vgabios.bin usr/share/kvm/vgabios.bin
+usr/share/vgabios/vgabios.cirrus.bin usr/share/kvm/vgabios-cirrus.bin
diff -urNw ../debian/kvm-53/debian/rules debian/rules
--- ../debian/kvm-53/debian/rules       2007-11-26 11:55:22.000000000 +0100
+++ debian/rules        2007-11-26 11:48:23.255340144 +0100
@@ -91,7 +91,7 @@
 
        # Add here command to compile/build the package.
        $(MAKE) qemu
-       $(MAKE) -C qemu/pc-bios
+#      $(MAKE) -C qemu/pc-bios
        touch $@
 
 # the binary-modules rule is invoked by module-assistant while processing the
@@ -142,7 +142,7 @@
        rm -f config.sub config.guess
 
        # Add here commands to clean up after the build process.
-       -$(MAKE) -C qemu/pc-bios clean
+#      -$(MAKE) -C qemu/pc-bios clean
        -$(MAKE) -C qemu distclean
        -$(MAKE) clean
 
@@ -155,7 +155,7 @@
 ifeq (1, 1)
 
 # Removing non-x86 bioses + linux_boot.bin which currently escapes to the metal
-unwanted_bios_files = ppc_rom.bin proll.elf openbios-sparc32 video.x 
linux_boot.bin pxe-ne2k_pci.bin pxe-pcnet.bin pxe-rtl8139.bin
+unwanted_bios_files = ppc_rom.bin openbios-sparc32 video.x pxe-ne2k_pci.bin 
pxe-pcnet.bin pxe-rtl8139.bin bios.bin vgabios.bin vgabios-cirrus.bin 
 
 else
 
@@ -173,10 +173,19 @@
        # Create the directories to install the source into
        dh_installdirs -p$(psource)  usr/src/modules/$(sname)/debian
 
+       # Make qemu's "make install" happy
+       for i in $(unwanted_bios_files); do \
+               touch qemu/pc-bios/$$i; \
+       done
        # Build & install normally, remove extraneous files
        $(MAKE) -C libkvm DESTDIR=$(CURDIR)/debian/$(sname) install
        $(MAKE) -C qemu DESTDIR=$(CURDIR)/debian/$(sname) install
 
+       # Clean up the mess
+       for i in $(unwanted_bios_files); do \
+               rm -f qemu/pc-bios/$$i debian/tmp/usr/share/kvm/$$i; \
+       done
+
        # Add here commands to install the package into debian/kvm.
        dh_install
        mv $(CURDIR)/debian/kvm/usr/bin/$(QEMU_EXE) 
$(CURDIR)/debian/kvm/usr/bin/kvm
@@ -284,4 +294,47 @@
 
 binary: binary-indep binary-arch
 
+# get-orig-source adapted from 
/usr/share/gnome-pkg-tools/1/rules/sf-get-source.mk from the gnome-pkg-tools 
package
+# copied from CDBS' buildvars
+DEB_SOURCE_PACKAGE ?= $(strip $(shell egrep '^Source: ' debian/control | cut 
-f 2 -d ':'))
+DEB_VERSION ?= $(shell dpkg-parsechangelog | egrep '^Version:' | cut -f 2 -d ' 
')
+DEB_NOEPOCH_VERSION ?= $(shell echo $(DEB_VERSION) | cut -d: -f2-)
+DEB_UPSTREAM_VERSION ?= $(shell echo $(DEB_NOEPOCH_VERSION) | sed 
's/+[^-]*-[^-]*$$//')
+
+# where to store the resulting .orig tarball
+DEB_TARBALL_DOWNLOAD_DIR ?= ../tarballs
+TARBALL_EXT ?= tar.gz
+
+SF_PROJECT ?= $(DEB_SOURCE_PACKAGE)
+SF_MODULE ?= $(DEB_SOURCE_PACKAGE)
+SF_TARBALL ?= $(SF_MODULE)-$(DEB_UPSTREAM_VERSION).$(TARBALL_EXT)
+SF_DOWNLOAD_URL ?= 
http://$$sf_mirror.dl.sourceforge.net/$(SF_PROJECT)/$(SF_TARBALL)
+SF_MIRRORS ?= belnet easynews heanet internap jaist kent mesh nchc optusnet 
ovh puzzle superb-east superb-west surfnet switch ufpr umn
+SF_DOWNLOAD_COMMAND ?= for sf_mirror in $(SF_MIRRORS); do wget -N -nv -T10 -t1 
-O 
$(DEB_TARBALL_DOWNLOAD_DIR)/$(DEB_SOURCE_PACKAGE)_$(DEB_UPSTREAM_VERSION).orig.$(TARBALL_EXT)
 $(SF_DOWNLOAD_URL) && break; done
+
+get-orig-source:
+       dh_testdir
+       @@echo 'Source package:                      $(DEB_SOURCE_PACKAGE)'
+       @@echo 'Source package:                      $(DEB_VERSION)'
+       @@echo 'Source version without epoch:        $(DEB_NOEPOCH_VERSION)'
+       @@echo 'Upstream version (for orig tarball): $(DEB_UPSTREAM_VERSION)'
+       mkdir -p $(DEB_TARBALL_DOWNLOAD_DIR)
+       $(SF_DOWNLOAD_COMMAND)
+       case "$(TARBALL_EXT)" in \
+       tar.bz2|tbz) \
+         bzcat 
$(DEB_TARBALL_DOWNLOAD_DIR)/$(DEB_SOURCE_PACKAGE)_$(DEB_UPSTREAM_VERSION).orig.$(TARBALL_EXT)
 | \
+         gzip -9 
>$(DEB_TARBALL_DOWNLOAD_DIR)/$(DEB_SOURCE_PACKAGE)_$(DEB_UPSTREAM_VERSION).orig.tar.gz
 ; \
+         rm -f 
$(DEB_TARBALL_DOWNLOAD_DIR)/$(DEB_SOURCE_PACKAGE)_$(DEB_UPSTREAM_VERSION).orig.$(TARBALL_EXT)
 \
+         ;;\
+       esac
+       cd $(DEB_TARBALL_DOWNLOAD_DIR) && \
+         tar xzf $(DEB_SOURCE_PACKAGE)_$(DEB_UPSTREAM_VERSION).orig.tar.gz && \
+         rm -f $(DEB_SOURCE_PACKAGE)-$(DEB_UPSTREAM_VERSION)/bios/VGABIOS* && \
+         rm -f $(DEB_SOURCE_PACKAGE)-$(DEB_UPSTREAM_VERSION)/bios/*.bin && \
+         rm -f 
$(DEB_SOURCE_PACKAGE)-$(DEB_UPSTREAM_VERSION)/qemu/pc-bios/openbios* && \
+         rm -f 
$(DEB_SOURCE_PACKAGE)-$(DEB_UPSTREAM_VERSION)/qemu/pc-bios/*.bin && \
+         tar c $(DEB_SOURCE_PACKAGE)-$(DEB_UPSTREAM_VERSION) | \
+         gzip -9 
>$(DEB_TARBALL_DOWNLOAD_DIR)/$(DEB_SOURCE_PACKAGE)_$(DEB_UPSTREAM_VERSION)+dfsg.orig.tar.gz
+
+
 .PHONY: build clean binary-indep binary-arch binary install  binary-modules 
kdist kdist_configure kdist_config kdist_image kdist_clean

--- End Message ---
--- Begin Message ---
Source: kvm
Source-Version: 55+dfsg-1

We believe that the bug you reported is fixed in the latest version of
kvm, which is due to be installed in the Debian FTP archive:

kvm-source_55+dfsg-1_all.deb
  to pool/main/k/kvm/kvm-source_55+dfsg-1_all.deb
kvm_55+dfsg-1.diff.gz
  to pool/main/k/kvm/kvm_55+dfsg-1.diff.gz
kvm_55+dfsg-1.dsc
  to pool/main/k/kvm/kvm_55+dfsg-1.dsc
kvm_55+dfsg-1_i386.deb
  to pool/main/k/kvm/kvm_55+dfsg-1_i386.deb
kvm_55+dfsg.orig.tar.gz
  to pool/main/k/kvm/kvm_55+dfsg.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jan Luebbe <[EMAIL PROTECTED]> (supplier of updated kvm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 07 Dec 2007 19:22:57 +0100
Source: kvm
Binary: kvm-source kvm
Architecture: source i386 all
Version: 55+dfsg-1
Distribution: unstable
Urgency: low
Maintainer: Jan Luebbe <[EMAIL PROTECTED]>
Changed-By: Jan Luebbe <[EMAIL PROTECTED]>
Description: 
 kvm        - Full virtualization on x86 hardware
 kvm-source - Source for the KVM driver
Closes: 452963
Changes: 
 kvm (55+dfsg-1) unstable; urgency=low
 .
   * New upstream release
   * Include cpu information also for bugs against kvm-source
   * Update upstream changelog
   * Remove bios.bin from upstream tarball (closes: #452963) and depend on the
     current version of bochsbios
Files: 
 7ebaae8154880a5a2d8808eda4b732cb 850 misc optional kvm_55+dfsg-1.dsc
 96e408444cebdd45669d5a46c1c9be2e 2564135 misc optional kvm_55+dfsg.orig.tar.gz
 c23621c60f1fc7fface758cccf6747dc 22140 misc optional kvm_55+dfsg-1.diff.gz
 60fd6331e807a7a1c3f6a11242207d5c 132150 misc optional 
kvm-source_55+dfsg-1_all.deb
 d9495680c5239fb25f49818a77a52e87 624056 misc optional kvm_55+dfsg-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHWZB5ioOL5NhIDy4RAgiHAKCtfxW3QPMpNj37QhGL8tqXpOAHbgCfVnUx
QzKRETDne9ja/CDKYBmZFhk=
=y+ZH
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to