Your message dated Sun, 15 May 2005 17:47:14 -0400 with message-id <[EMAIL PROTECTED]> and subject line Bug#309119: fixed in rhythmbox 0.8.8-13 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database) -------------------------------------- Received: (at submit) by bugs.debian.org; 14 May 2005 18:47:28 +0000 >From [EMAIL PROTECTED] Sat May 14 11:47:28 2005 Return-path: <[EMAIL PROTECTED]> Received: from ppsw-0.csi.cam.ac.uk [131.111.8.130] by spohr.debian.org with esmtp (Exim 3.35 1 (Debian)) id 1DX1fb-0005rz-00; Sat, 14 May 2005 11:47:27 -0700 X-Cam-SpamDetails: Not scanned X-Cam-AntiVirus: No virus found X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from quadrant.corpus.cam.ac.uk ([131.111.235.202]:33367 helo=alpha.mcnet) by ppsw-0.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.130]:25) with esmtp id 1DX1fU-0007UV-1C (Exim 4.51) (return-path <[EMAIL PROTECTED]>); Sat, 14 May 2005 19:47:20 +0100 Received: by alpha.mcnet (Postfix, from userid 1000) id 5EDC9302F445; Sat, 14 May 2005 19:47:19 +0100 (BST) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Robert McQueen <[EMAIL PROTECTED]> To: Debian Bug Tracking System <[EMAIL PROTECTED]> Subject: rhythmbox: fails to check return value when writing playlists to disk X-Mailer: reportbug 3.11 Date: Sat, 14 May 2005 19:47:18 +0100 Message-Id: <[EMAIL PROTECTED]> Delivered-To: [EMAIL PROTECTED] X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Status: No, hits=-6.8 required=4.0 tests=BAYES_00,FROM_ENDS_IN_NUMS, HAS_PACKAGE autolearn=no version=2.60-bugs.debian.org_2005_01_02 X-Spam-Level: Package: rhythmbox Version: 0.8.8-11 Severity: grave Justification: causes non-serious data loss I just ran out of disk space in ~, and rhythmbox just destroyed my playlist file. In the function rb_playlist_manager_save_thread_main in shell/rb-playlist-manager.c, it calls xmlSaveFormatFile to write the playlist to a temporary file, but does not check the return value of this function before renaming the temporary file to playlists.xml, clobbering the original and losing my playlists in the process. As detailed in http://xmlsoft.org/html/libxml-tree.html#xmlSaveFormatFile, the function returns -1 if an error was encountered. Rhythmbox should only rename the temporary file to the original name if this was not the case. Regards, Rob -- System Information: Debian Release: 3.1 APT prefers unstable APT policy: (990, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.10-alpha2 Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Versions of packages rhythmbox depends on: ii gconf2 2.8.1-5 GNOME configuration database syste ii gstreamer0.8-alsa [g 0.8.8-3 ALSA plugin for GStreamer ii gstreamer0.8-esd [gs 0.8.8-3 Enlightened Sound Daemon plugin fo ii gstreamer0.8-flac 0.8.8-3 FLAC plugin for GStreamer ii gstreamer0.8-gnomevf 0.8.8-3 Gnome VFS plugin for GStreamer ii gstreamer0.8-mad 0.8.8-3 MAD MPEG audio decoder plugin for ii gstreamer0.8-misc 0.8.8-3 Collection of various GStreamer pl ii gstreamer0.8-oss [gs 0.8.8-3 OSS plugin for GStreamer ii gstreamer0.8-vorbis 0.8.8-3 Vorbis plugin for GStreamer ii libart-2.0-2 2.3.17-1 Library of functions for 2D graphi ii libatk1.0-0 1.8.0-4 The ATK accessibility toolkit ii libaudiofile0 0.2.6-6 Open-source version of SGI's audio ii libbonobo2-0 2.8.1-2 Bonobo CORBA interfaces library ii libbonoboui2-0 2.8.1-2 The Bonobo UI library ii libc6 2.3.5-1 GNU C Library: Shared libraries an ii libesd0 0.2.35-2.1 Enlightened Sound Daemon - Shared ii libgconf2-4 2.8.1-5 GNOME configuration database syste ii libgcrypt11 1.2.0-11 LGPL Crypto library - runtime libr ii libglade2-0 1:2.4.2-2 library to load .glade files at ru ii libglib2.0-0 2.6.4-1 The GLib library of C routines ii libgnome-keyring0 0.4.2-1 GNOME keyring services library ii libgnome2-0 2.8.1-2 The GNOME 2 library - runtime file ii libgnomecanvas2-0 2.8.0-1 A powerful object-oriented display ii libgnomeui-0 2.8.1-3 The GNOME 2 libraries (User Interf ii libgnomevfs2-0 2.8.4-3 The GNOME virtual file-system libr ii libgnutls11 1.0.16-13 GNU TLS library - runtime library ii libgpg-error0 1.0-1 library for common error values an ii libgstreamer-gconf0. 0.8.8-3 GConf support for GStreamer ii libgstreamer0.8-0 0.8.9-2 Core GStreamer libraries, plugins, ii libgtk2.0-0 2.6.4-1 The GTK+ graphical user interface ii libice6 4.3.0.dfsg.1-12.0.1 Inter-Client Exchange library ii libjpeg62 6b-10 The Independent JPEG Group's JPEG ii liborbit2 1:2.12.2-1 libraries for ORBit2 - a CORBA ORB ii libpango1.0-0 1.8.1-1 Layout and rendering of internatio ii libpopt0 1.7-5 lib for parsing cmdline parameters ii libsm6 4.3.0.dfsg.1-12.0.1 X Window System Session Management ii libtasn1-2 0.2.10-4 Manage ASN.1 structures (runtime) ii libx11-6 6.8.2-10 X Window System protocol client li ii libxml2 2.6.16-7 GNOME XML library ii xlibs 4.3.0.dfsg.1-12 X Keyboard Extension (XKB) configu ii zlib1g 1:1.2.2-4 compression library - runtime -- no debconf information --------------------------------------- Received: (at 309119-close) by bugs.debian.org; 15 May 2005 21:53:35 +0000 >From [EMAIL PROTECTED] Sun May 15 14:53:35 2005 Return-path: <[EMAIL PROTECTED]> Received: from newraff.debian.org [208.185.25.31] (mail) by spohr.debian.org with esmtp (Exim 3.35 1 (Debian)) id 1DXR3G-0002x4-00; Sun, 15 May 2005 14:53:34 -0700 Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian)) id 1DXQx8-0001fo-00; Sun, 15 May 2005 17:47:14 -0400 From: Loic Minier <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] X-Katie: $Revision: 1.55 $ Subject: Bug#309119: fixed in rhythmbox 0.8.8-13 Message-Id: <[EMAIL PROTECTED]> Sender: Archive Administrator <[EMAIL PROTECTED]> Date: Sun, 15 May 2005 17:47:14 -0400 Delivered-To: [EMAIL PROTECTED] X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2005_01_02 X-Spam-Level: X-CrossAssassin-Score: 2 Source: rhythmbox Source-Version: 0.8.8-13 We believe that the bug you reported is fixed in the latest version of rhythmbox, which is due to be installed in the Debian FTP archive: rhythmbox_0.8.8-13.diff.gz to pool/main/r/rhythmbox/rhythmbox_0.8.8-13.diff.gz rhythmbox_0.8.8-13.dsc to pool/main/r/rhythmbox/rhythmbox_0.8.8-13.dsc rhythmbox_0.8.8-13_i386.deb to pool/main/r/rhythmbox/rhythmbox_0.8.8-13_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Loic Minier <[EMAIL PROTECTED]> (supplier of updated rhythmbox package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sun, 15 May 2005 20:42:12 +0200 Source: rhythmbox Binary: rhythmbox Architecture: source i386 Version: 0.8.8-13 Distribution: unstable Urgency: high Maintainer: Loic Minier <[EMAIL PROTECTED]> Changed-By: Loic Minier <[EMAIL PROTECTED]> Description: rhythmbox - music player and organizer for GNOME Closes: 257838 309119 Changes: rhythmbox (0.8.8-13) unstable; urgency=high . * urgency high for Sarge targetted RC bugfix * check the return code of xmlSaveFormatFile when saving playlists, fixes data loss when disk is full (closes: #309119). Thanks to Robert McQueen. [debian/patches/50_debian_xmlsaveformatfile_check.patch] * fix a bug introduced with the 40_debian_geometry_hints patch where one couldn't resize the small version of the GUI (closes: #257838) [debian/patches/40_debian_geometry_hints.patch] Files: c5512065ce389c8482c75f67d9ab6df2 1838 gnome optional rhythmbox_0.8.8-13.dsc 9c6e1f94feefcb8c62d0dc136b066654 28468 gnome optional rhythmbox_0.8.8-13.diff.gz 845b3bac17cd06eb712ff6bbac7e239c 1883186 gnome optional rhythmbox_0.8.8-13_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFCh76hCw8pKd+B7oMRArEEAJ45172HnO6VhR4wZxHgAacmJW8stACfehxI 6Ikmq6bnaH6dXyf2fg70ygU= =xere -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]