Bug#297279: marked as done (zangband: FTBFS (amd64/gcc-4.0): initializer element is not constant)

[Debian Bug Tracking System]

Your message dated Wed, 10 Oct 2007 14:32:07 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#297279: fixed in zangband 1:2.7.5pre1-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---

Package: zangband
Severity: normal
Tags: patch

When building 'zangband' on amd64 with gcc-4.0,
I get the following error:

src/main-gtk.c:2254: error: (near initialization for 
'main_menu_items[14].callback_action')
src/main-gtk.c:2265: error: initializer element is not constant
src/main-gtk.c:2265: error: (near initialization for 
'main_menu_items[17].callback_action')
src/main-gtk.c:2267: error: initializer element is not constant
src/main-gtk.c:2267: error: (near initialization for 
'main_menu_items[18].callback_action')
src/main-gtk.c:2269: error: initializer element is not constant
src/main-gtk.c:2269: error: (near initialization for 
'main_menu_items[19].callback_action')
src/main-gtk.c:2271: error: initializer element is not constant
src/main-gtk.c:2271: error: (near initialization for 
'main_menu_items[20].callback_action')
src/main-gtk.c:2273: error: initializer element is not constant
src/main-gtk.c:2273: error: (near initialization for 
'main_menu_items[21].callback_action')
src/main-gtk.c:2275: error: initializer element is not constant
src/main-gtk.c:2275: error: (near initialization for 
'main_menu_items[22].callback_action')
src/main-gtk.c:2277: error: initializer element is not constant
src/main-gtk.c:2277: error: (near initialization for 
'main_menu_items[23].callback_action')
src/main-gtk.c:2279: error: initializer element is not constant
src/main-gtk.c:2279: error: (near initialization for 
'main_menu_items[24].callback_action')
make[1]: *** [src/main-gtk.o] Error 1
make[1]: Leaving directory `/zangband-2.7.3'
make: *** [build-stamp] Error 2

With the attached patch 'zangband' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/zangband-2.7.3/src/main-gtk.c ./src/main-gtk.c
--- ../tmp-orig/zangband-2.7.3/src/main-gtk.c   2003-04-05 19:02:02.000000000 
+0000
+++ ./src/main-gtk.c    2005-02-28 13:00:01.294987859 +0000
@@ -1218,7 +1218,7 @@
 {
        GtkWidget *font_selector = gtk_font_selection_dialog_new("Select font");
 
-       term_data *td = user_data;
+       term_data *td = (term_data*) &data[(long)user_data];
        gchar *foundery[] = { (char * ) "misc", NULL};
        gchar *spacings[] = { (char * ) "c", (char *) "m", NULL };
        gchar *charsets[] = { (char * ) "iso8859-1", NULL};
@@ -1263,7 +1263,7 @@
  */
 static void term_event_handler(GtkWidget *widget, gpointer user_data)
 {
-       term_data *td = (term_data *)user_data;
+       term_data *td = (term_data *) &data[(long)user_data];
        
        /* Ignore unused parameter */
        (void) widget;
@@ -2237,21 +2237,21 @@
          NULL, 0, (char * ) "<Branch>" },
        /* XXX XXX XXX NULL's are replaced by the program */
        { NULL, (char * ) "<mod1>0",
-         term_event_handler, (guint)&data[0], (char * ) "<CheckItem>" },
+         term_event_handler, 0, (char * ) "<CheckItem>" },
        { NULL, (char * ) "<mod1>1",
-         term_event_handler, (guint)&data[1], (char * ) "<CheckItem>" },
+         term_event_handler, 1, (char * ) "<CheckItem>" },
        { NULL, (char * ) "<mod1>2",
-         term_event_handler, (guint)&data[2], (char * ) "<CheckItem>" },
+         term_event_handler, 2, (char * ) "<CheckItem>" },
        { NULL, (char * ) "<mod1>3",
-         term_event_handler, (guint)&data[3], (char * ) "<CheckItem>" },
+         term_event_handler, 3, (char * ) "<CheckItem>" },
        { NULL, (char * ) "<mod1>4",
-         term_event_handler, (guint)&data[4], (char * ) "<CheckItem>" },
+         term_event_handler, 4, (char * ) "<CheckItem>" },
        { NULL, (char * ) "<mod1>5",
-         term_event_handler, (guint)&data[5], (char * ) "<CheckItem>" },
+         term_event_handler, 5, (char * ) "<CheckItem>" },
        { NULL, (char * ) "<mod1>6",
-         term_event_handler, (guint)&data[6], (char * ) "<CheckItem>" },
+         term_event_handler, 6, (char * ) "<CheckItem>" },
        { NULL, (char * ) "<mod1>7",
-         term_event_handler, (guint)&data[7], (char * ) "<CheckItem>" },
+         term_event_handler, 7, (char * ) "<CheckItem>" },
 
        /* "Options" menu */
        { (char * ) "/Options", NULL,
@@ -2262,21 +2262,21 @@
          NULL, 0, (char * ) "<Branch>" },
        /* XXX XXX XXX Again, NULL's are filled by the program */
        { NULL, NULL,
-         change_font_event_handler, (guint)&data[0], NULL },
+         change_font_event_handler, 0, NULL },
        { NULL, NULL,
-         change_font_event_handler, (guint)&data[1], NULL },
+         change_font_event_handler, 1, NULL },
        { NULL, NULL,
-         change_font_event_handler, (guint)&data[2], NULL },
+         change_font_event_handler, 2, NULL },
        { NULL, NULL,
-         change_font_event_handler, (guint)&data[3], NULL },
+         change_font_event_handler, 3, NULL },
        { NULL, NULL,
-         change_font_event_handler, (guint)&data[4], NULL },
+         change_font_event_handler, 4, NULL },
        { NULL, NULL,
-         change_font_event_handler, (guint)&data[5], NULL },
+         change_font_event_handler, 5, NULL },
        { NULL, NULL,
-         change_font_event_handler, (guint)&data[6], NULL },
+         change_font_event_handler, 6, NULL },
        { NULL, NULL,
-         change_font_event_handler, (guint)&data[7], NULL },
+         change_font_event_handler, 7, NULL },
 
 #ifdef USE_GRAPHICS
 

--- End Message ---

--- Begin Message ---

Source: zangband
Source-Version: 1:2.7.5pre1-1

We believe that the bug you reported is fixed in the latest version of
zangband, which is due to be installed in the Debian FTP archive:

zangband_2.7.5pre1-1.diff.gz
  to pool/non-free/z/zangband/zangband_2.7.5pre1-1.diff.gz
zangband_2.7.5pre1-1.dsc
  to pool/non-free/z/zangband/zangband_2.7.5pre1-1.dsc
zangband_2.7.5pre1-1_i386.deb
  to pool/non-free/z/zangband/zangband_2.7.5pre1-1_i386.deb
zangband_2.7.5pre1.orig.tar.gz
  to pool/non-free/z/zangband/zangband_2.7.5pre1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Drew Parsons <[EMAIL PROTECTED]> (supplier of updated zangband package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 10 Oct 2007 23:38:36 +1000
Source: zangband
Binary: zangband
Architecture: source i386
Version: 1:2.7.5pre1-1
Distribution: unstable
Urgency: low
Maintainer: Drew Parsons <[EMAIL PROTECTED]>
Changed-By: Drew Parsons <[EMAIL PROTECTED]>
Description: 
 zangband   - A single-player, text-based, roguelike game
Closes: 297279 346946 412860 423190
Changes: 
 zangband (1:2.7.5pre1-1) unstable; urgency=low
 .
   * New maintainer (adopting this poor neglected program). Hey, I've
     got the oldest unclosed bug report, so that gives me seniority.
     Closes: #423190.
   * New upstream version.  Closes: #412860.
   * Update with autoreconf, copy fresh config.sub,config.guess from
     /usr/share/automake-1.9.
   * Thank you Steinar H. Gunderson for the NMUs.
     Closes: #297279, #346946.
   * Patches now managed by quilt.
   * Standards version 3.7.2.
   * Help command (man page) is ? not \?.
Files: 
 0014b5676a6829ff60c467a9ec5f238b 700 non-free/games optional 
zangband_2.7.5pre1-1.dsc
 8ea43c1b13c54157558bfd0ad3cee295 2835426 non-free/games optional 
zangband_2.7.5pre1.orig.tar.gz
 0230f2e4e929ce320c93cddfeb8585a7 89503 non-free/games optional 
zangband_2.7.5pre1-1.diff.gz
 d317017c46c2c89a39723330eab21749 2018808 non-free/games optional 
zangband_2.7.5pre1-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHDNfzts5wQWQSTkoRAu1yAJ9jKeZZeTJPd5XMogpfi/niRcsgowCfVtZO
dazzNo92yz24U1gQdoZPj6k=
=7+I9
-----END PGP SIGNATURE-----

--- End Message ---