Richard A Nelson <[EMAIL PROTECTED]> writes:
> Package: openafs-modules-source
> Version: 1.4.4.dfsg1-7
> Severity: grave
> Justification: renders package unusable
> I just built a new x86_64 machine to bridge AFS/NFS/CIFS and after
> logging in to an AFS id, I found this:
We think we've tracked this down to not a kernel revision but the upgrade
from gcc to 4.2, and specifically its treatment of signed integer overflow
as undefined.
Could you try this patch and see if it fixes the problem for you?
Index: src/dir/dir.c
===================================================================
RCS file: /cvs/openafs/src/dir/dir.c,v
retrieving revision 1.24
diff -u -r1.24 dir.c
--- src/dir/dir.c 13 Oct 2005 15:12:12 -0000 1.24
+++ src/dir/dir.c 7 Oct 2007 17:10:37 -0000
@@ -478,8 +478,9 @@
{
/* Hash a string to a number between 0 and NHASHENT. */
register unsigned char tc;
- register int hval;
+ unsigned long hval;
register int tval;
+
hval = 0;
while ((tc = (*string++))) {
hval *= 173;
@@ -488,7 +489,7 @@
tval = hval & (NHASHENT - 1);
if (tval == 0)
return tval;
- else if (hval < 0)
+ else if (hval >= 1<<31)
tval = NHASHENT - tval;
return tval;
}
--
Russ Allbery ([EMAIL PROTECTED]) <http://www.eyrie.org/~eagle/>
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
