tag 444634 patch
forwarded 444634 http://rt.cpan.org/Public/Bug/Display.html?id=29455
thanks
On Mon, Oct 01, 2007 at 09:08:21AM +0200, Lucas Nussbaum wrote:
> On 30/09/07 at 22:26 +0300, Niko Tyni wrote:
> > > Useless content call in void context at /usr/share/perl5/LWP/Simple.pm
> > > line 150
> > I don't see these either. I wonder if it's related.
It indeed is. The problem is $ENV{http_proxy}. The test scripts
set up a local web server and then connect to it via the 'external'
address of the host. Almost all of the test scripts delete http_proxy
from the environment, with the exception of t/24-source-file.t.
If http_proxy is set and the test web server isn't reachable by the
proxy, t/24-source-file.t can't send 'GET /quit_server' to the server
and the server never exits, while the test script hangs waiting
for the child to terminate.
This is also CPAN #29455. I just sent the comments there as well.
The 'Useless content call' messages come from the same code path (ie. when
http_proxy is set) and happen because Test::HTTP::LocalServer::stop()
calls LWP::Simple::get() in a void context. Checking the result would
be a good idea, and I have suggested it upstream.
The simplest fix is to unset http_proxy and HTTP_PROXY in debian/rules
when calling the 'test' target. Patch attached.
Cheers,
--
Niko Tyni [EMAIL PROTECTED]
diff --git a/debian/rules b/debian/rules
index f51aa6a..e764d19 100755
--- a/debian/rules
+++ b/debian/rules
@@ -26,7 +26,7 @@ build-stamp:
# Add commands to compile the package here
$(PERL) Makefile.PL INSTALLDIRS=vendor
$(MAKE)
- $(MAKE) test
+ HTTP_PROXY= http_proxy= $(MAKE) test
touch build-stamp
