Your message dated Wed, 11 May 2005 12:34:57 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Bug#301370: marked as done (quota postrm fails due to missing
dependency)
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 25 Mar 2005 12:31:43 +0000
>From [EMAIL PROTECTED] Fri Mar 25 04:31:42 2005
Return-path: <[EMAIL PROTECTED]>
Received: from s2.ukfsn.org (mail.ukfsn.org) [217.158.120.143]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DEnyY-0005PF-00; Fri, 25 Mar 2005 04:31:42 -0800
Received: from localhost (lucy.ukfsn.org [127.0.0.1])
by mail.ukfsn.org (Postfix) with ESMTP
id 559A5E6D64; Fri, 25 Mar 2005 12:30:51 +0000 (GMT)
Received: from mail.ukfsn.org ([127.0.0.1])
by localhost (lucy.ukfsn.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id 03190-17; Fri, 25 Mar 2005 12:30:51 +0000 (GMT)
Received: from hardknott.home.whinlatter.ukfsn.org
(dsl-80-41-7-233.access.as9105.com [80.41.7.233])
by mail.ukfsn.org (Postfix) with ESMTP
id E2FC4E6A9F; Fri, 25 Mar 2005 12:30:50 +0000 (GMT)
Received: from rleigh by hardknott.home.whinlatter.ukfsn.org with local (Exim
4.50)
id 1DEnoG-0001E8-9D; Fri, 25 Mar 2005 12:21:04 +0000
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Roger Leigh <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: quota postrm fails due to missing dependency
X-Mailer: reportbug 3.9
Date: Fri, 25 Mar 2005 12:21:04 +0000
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: quota
Version: 3.12-4
Severity: important
The quota postrm script calls "update-inetd" without a dependeny on the
package containing update-inetd nor a check to see if the script exists.
This causes the postrm to fail on systems lacking update-inetd.
Suggested fix:
1) Add a netbase dependency
or
2) Check if update-inetd exists before trying to run it.
In this case (2) is probably the better choice.
Regards,
Roger
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (990, 'unstable')
Architecture: powerpc (ppc)
Kernel: Linux 2.6.8-powerpc
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages quota depends on:
ii debconf 1.4.46 Debian configuration management sy
ii e2fslibs 1.37-1 ext2 filesystem libraries
ii libc6 2.3.2.ds1-20 GNU C Library: Shared libraries an
ii libcomerr2 1.37-1 common error description library
ii libwrap0 7.6.dbs-8 Wietse Venema's TCP wrappers libra
-- debconf information excluded
---------------------------------------
Received: (at 301370-done) by bugs.debian.org; 11 May 2005 10:35:05 +0000
>From michael@fam-meskes.de Wed May 11 03:35:05 2005
Return-path: <michael@fam-meskes.de>
Received: from moutng.kundenserver.de [212.227.126.186]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DVoYS-0000hs-00; Wed, 11 May 2005 03:35:04 -0700
Received: from p508904D9.dip0.t-ipconnect.de[80.137.4.217] (helo=feivel)
by mrelayeu.kundenserver.de with ESMTP (Nemesis),
id 0ML2Dk-1DVoYP26cp-0002og; Wed, 11 May 2005 12:35:01 +0200
Received: by feivel (Postfix, from userid 1000)
id 857664AC15; Wed, 11 May 2005 12:34:58 +0200 (CEST)
Date: Wed, 11 May 2005 12:34:57 +0200
From: Michael Meskes <[EMAIL PROTECTED]>
To: debian-release@lists.debian.org, [EMAIL PROTECTED],
[EMAIL PROTECTED]
Subject: Re: Bug#301370: marked as done (quota postrm fails due to missing
dependency)
Message-ID: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL
PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z"
Content-Disposition: inline
In-Reply-To: <[EMAIL PROTECTED]>
User-Agent: Mutt/1.5.9i
X-Provags-ID: kundenserver.de [EMAIL PROTECTED]
login:da5cff6069dd6897c77170232368d0ba
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 2
--Nq2Wo0NMKNjxTN9z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Steve,
> There appear to be a number of undocumented changes, relative to -4, which
> are not documentation fixes. :/ Would you remind removing them and
> uploading a -4sarge1 to testing-proposed-updates, or else explain why the=
se
> changes are warranted during the freeze?
Please take my apologies. I was interrupted while working on the package
and simply forgot to remove some parts of the whole patch I applied.
Also I didn't complete the changelog entry. And you probably noticed
that stray patch file lying around in the source tree. Argh!
I fixed this and am currently uploading -6 which should be okay. It
still contains two non-doc patches:
diff -ruN tmp/quota-3.12/quotaops.c quota-3.12/quotaops.c
--- tmp/quota-3.12/quotaops.c 2005-05-11 11:58:35.000000000 +0200
+++ quota-3.12/quotaops.c 2005-05-11 11:58:16.000000000 +0200
@@ -34,7 +34,7 @@
=20
#ident "$Copyright: (c) 1980, 1990 Regents of the University of California=
=2E $"
#ident "$Copyright: All rights reserved. $"
-#ident "$Id: quotaops.c,v 1.14 2004/05/24 19:39:15 jkar8572 Exp $"
+#ident "$Id: quotaops.c,v 1.16 2005/03/31 11:48:02 jkar8572 Exp $"
=20
#include <rpc/rpc.h>
#include <sys/types.h>
@@ -72,13 +72,13 @@
time_t now;
=20
time(&now);
- if (q->dq_dqb.dqb_bsoftlimit && toqb(q->dq_dqb.dqb_curspace) >=3D
q->dq_d=
qb.dqb_bsoftlimit) {
+ if (q->dq_dqb.dqb_bsoftlimit && toqb(q->dq_dqb.dqb_curspace) >
q->dq_dqb.=
dqb_bsoftlimit) {
if (!q->dq_dqb.dqb_btime)
q->dq_dqb.dqb_btime =3D now +
q->dq_h->qh_info.dqi_bgrace;
}
else
q->dq_dqb.dqb_btime =3D 0;
- if (q->dq_dqb.dqb_isoftlimit && q->dq_dqb.dqb_curinodes >=3D
q->dq_dqb.dq=
b_isoftlimit) {
+ if (q->dq_dqb.dqb_isoftlimit && q->dq_dqb.dqb_curinodes >
q->dq_dqb.dqb_i=
softlimit) {
if (!q->dq_dqb.dqb_itime)
q->dq_dqb.dqb_itime =3D now +
q->dq_h->qh_info.dqi_igrace;
}
[...]
This one fixes the bug that grace time was set when reaching the limit
instead of starting it when exceeding the limit.
diff -ruN tmp/quota-3.12/rquota_client.c quota-3.12/rquota_client.c
--- tmp/quota-3.12/rquota_client.c 2004-02-12 10:45:14.000000000 +0100
+++ quota-3.12/rquota_client.c 2005-05-11 11:58:16.000000000 +0200
@@ -149,8 +149,10 @@
* Strip off pathname on nfs mounted dir. Ignore entries of any
* automounter.
*/
- if ((pathname =3D strchr(fsname_tmp, ':')) =3D=3D (char *)0 ||
*(pathname=
+ 1) =3D=3D '(')
+ if ((pathname =3D strchr(fsname_tmp, ':')) =3D=3D (char *)0 ||
*(pathname=
+ 1) =3D=3D '(') {
+ free(fsname_tmp);
return -ENOENT;
+ }
=20
*pathname++ =3D '\0';
This one obviously fixes a memory leak. It's not that serious but I
rather have it fixed for sarge too.
> Incidentally, I'm puzzled why quota is calling update-inetd at all from t=
he
> postrm, since there's no code in the postinst which adds an inetd entry.=
=20
> That shouldn't be a blocker for sarge, though.
You're right. That's why I removed the line completely.
Michael
--=20
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!
--Nq2Wo0NMKNjxTN9z
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCgd/RVkEm8inxm9ERAmHnAJsEOzsut3I1nZOo0LdxeGsxov2q+ACfXGfb
9FyldHRj6ecpjvRvTOOnPdU=
=DMrj
-----END PGP SIGNATURE-----
--Nq2Wo0NMKNjxTN9z--
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
