On Sun, Sep 09, 2007 at 06:28:15PM +0200, gimmy wrote:
> Package: xarchiver
> Version: 0.4.6-4
> Severity: important
> 
> Xarchiver fails to start.
> This is what I got the first time.
> Next time I try to start xarchiver it just hangs.
> 
> (xarchiver:3422): Gtk-WARNING **: Theme file for default has no name
> 
> 
> (xarchiver:3422): Gtk-WARNING **: Theme file for default has no directories
> 
> *** glibc detected *** xarchiver: double free or corruption (out): 0x08153230 
> ***

xarchiver uses g_free instead of g_error_free to free GErrors (which are
allocated using the slice allocater, not malloc)..

The attached patch fixes enough of to get the main window to show :) There
might be more similar issues

  Sjoerd
-- 
Power corrupts.  And atomic power corrupts atomically.
diff -Naur xarchiver-0.4.6-vanilla/src/support.c xarchiver-0.4.6/src/support.c
--- xarchiver-0.4.6-vanilla/src/support.c	2007-09-22 20:12:45.000000000 +0200
+++ xarchiver-0.4.6/src/support.c	2007-09-22 20:13:08.000000000 +0200
@@ -38,7 +38,7 @@
 	if ( file_pixbuf == NULL )
 	{
 		/* perhaps xarchiver has not been installed and is being executed from source dir */
-		g_free (error);
+		g_error_free (error);
 		error = NULL;
 		path = g_strconcat("./pixmaps/", filename, NULL);
 		file_pixbuf = gdk_pixbuf_new_from_file (path, &error);
@@ -51,7 +51,7 @@
     }
     else
 	{
-		g_free(error);
+		g_error_free(error);
 		file_image = gtk_image_new_from_stock(GTK_STOCK_MISSING_IMAGE, size);
     }
     return file_image;

Reply via email to