tag 414702 patch
thanks

Frank Lichtenheld <[EMAIL PROTECTED]> (13/03/2007):
> your package failed to build from source because libpng-dev was needed
> but not build-depend upon. Feel free to clone this bug and reassign it
> to libvtk5-dev if you feel that this package should depend on
> libpng-dev.

In both cases, the fix is known, tagging this bugreport accordingly.

> One issue would still remain in this case and that is that the build
> should really have failed after the first file failed to compile and
> not much later during the packaging stage.

That is due to the use of make's `-i' option (`--ignore-errors',
seeĀ [1]).

 1. http://www.gnu.org/software/make/manual/make.html#Options-Summary

Quick check:
$ dpkg-source -x therion_0.5.0-1.dsc
$ cd therion-0.5.0
$ tar xfz therion-0.5.0.tar.gz
$ find therion -name Makefile -exec grep -Hn -- -i {} ';'
therion/Makefile:152:   make -i -C ./xtherion
therion/Makefile:155:   make -i -C ./loch
therion/loch/help/Makefile:2:   make -i -C ./en
therion/loch/help/Makefile:3:   make -i -C ./sk

Deleting the -i option allows a correct build if libpng(12)-dev is installed,
and a `normal' failure otherwise.

Cheers,

-- 
Cyril Brulebois

Attachment: pgpzyXtxdpdh1.pgp
Description: PGP signature

Reply via email to