On Sun, 5 Sep 2004, Ian Jackson wrote:

> Roland Stigge writes ("Bug#263979: userv FTBFS"):
> > tag 263979 patch
> > thanks
> > 
> > On Sat, 2004-08-14 at 00:59, Moray Allan wrote:
> > > Can you confirm for the bug log whether this problem disappears when you
> > > add SHELL=/bin/bash at the top of debian/rules?
> > 
> > Yes.
> 
> Oh, good, I see someone else already asked this.  This is a good fix
> then.
> 
> Ian.

Alternatively, you could rewrite debian/rules so that it does not use
bashisms. With a little bit of care, debian/rules does not become a
lot longer.

The following patch works for me:

diff -ru userv-1.0.3.orig/debian/rules userv-1.0.3/debian/rules
--- userv-1.0.3.orig/debian/rules       2003-10-31 23:55:41.000000000 +0100
+++ userv-1.0.3/debian/rules    2005-01-27 19:44:22.000000000 +0100
@@ -32,14 +32,15 @@
 binary-arch:   checkroot build
        $(checkdir)
        -rm -rf $t
-       install -d $t/{DEBIAN,etc/init.d} $t/usr/{sbin,bin}
-       install -d $t/etc/userv/{override,default}.d
+       install -d $t
+       cd $t && install -d DEBIAN etc/init.d usr/sbin usr/bin \
+               etc/userv/override.d etc/userv/default.d
        install -d $t/usr/share/doc/$(package)/examples/
        install -d $t/var/run/$(package)/
        install -d $t/usr/share/lintian/overrides/
-       cp debian/{postinst,prerm,postrm,conffiles} $t/DEBIAN/.
+       cd debian && cp postinst prerm postrm conffiles tmp/DEBIAN/.
        cp debian/initd $t/etc/init.d/userv
-       chmod 755 $t/DEBIAN/{postinst,prerm,postrm}
+       cd $t/DEBIAN && chmod 755 postinst prerm postrm
        chmod 755 $t/etc/init.d/userv
        $(MAKE) $(INSTOPTS) \
                prefix=$t/usr etcdir=$t/etc \


It could be made even shorter if you use install -m 755 for the
maintainer scripts instead of cp followed by chmod.

Shell scripts using /bin/sh are a *lot* faster when sh is dash.
IMHO, if we could all get used to write portable sh code, it would be
better for everybody in the long term.

Thanks.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to