Your message dated Fri, 14 Jan 2005 14:02:06 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#290456: fixed in amavis-ng 0.1.6.9-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 14 Jan 2005 08:57:30 +0000
>From [EMAIL PROTECTED] Fri Jan 14 00:57:30 2005
Return-path: <[EMAIL PROTECTED]>
Received: from pd952c810.dip.t-dialin.net (localhost) [217.82.200.16] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1CpNGq-0003gc-00; Fri, 14 Jan 2005 00:57:29 -0800
Received: from amavis by localhost with scanned-ok (Exim 3.36 #1 (Debian))
        id 1CpNK5-00011Q-00
        for <[EMAIL PROTECTED]>; Fri, 14 Jan 2005 10:00:49 +0100
Received: from sb by localhost with local (Exim 3.36 #1 (Debian))
        id 1CpNK4-00011F-00; Fri, 14 Jan 2005 10:00:48 +0100
Content-Type: multipart/mixed; boundary="===============0306671289=="
MIME-Version: 1.0
From: Sebastian Bleikamp <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: amavis-ng: Exim.pm in 1.6.8-1 still bugged - patch included.
X-Mailer: reportbug 3.5
Date: Fri, 14 Jan 2005 10:00:44 +0100
Message-Id: <[EMAIL PROTECTED]>
Sender: Sebastian <[EMAIL PROTECTED]>
X-Scanned-By: AMaViS-ng at Shuttle508.
X-BadReturnPath: [EMAIL PROTECTED] rewritten as [EMAIL PROTECTED]
  using "From" header
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

This is a multi-part MIME message sent by reportbug.

--===============0306671289==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: amavis-ng
Version: 0.1.6.8-1
Severity: grave
Tags: patch
Justification: renders package unusable




Hi !

There is still the problem with amavis-ng and the Exim.pm module. On an debian 
unstable system, the variables "exim" and "args" cannot be passed due to a
programming error, making the whole program abort.


Fix:
Exchange the two lines (l.32/l.33) in Exim.pm as follows:

$cfg_exim_binary = $AMAVIS::cfg->val('Exim' , 'exim');
$cfg_exim_args = $AMAVIS::cfg->val('Exim', 'args' );


This is the same as in most of the other scripts. It simply does not the buggy
default value check. Sorry, I am not a professional in perl so I cannot tell you
exactly what the syntax error is in the original files.

Best regards,
Sebastian




-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.8
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages amavis-ng depends on:
ii  debconf                       1.4.41     Debian configuration management sy
ii  libconfig-inifiles-perl       2.38-3     Read .ini-style configuration file
ii  libfile-mmagic-perl           1.22-1     Perl module to guess file type
ii  libmime-perl                  5.415-1    Perl5 modules for MIME-compliant m
ii  libnet-perl                   1:1.19-1   Implementation of Internet protoco
ii  logrotate                     3.7-2      Log rotation utility
ii  perl [libmime-base64-perl]    5.8.4-5    Larry Wall's Practical Extraction 
ii  perl-modules [libnet-perl]    5.8.4-5    Core Perl modules
ii  perl-suid                     5.8.4-5    Runs setuid Perl scripts

-- debconf information:
  amavis-ng/filename-changes:

--===============0306671289==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="Exim.pm"

# $Id: Exim.pm,v 1.22 2005/01/13 00:14:33 braeucup Exp $

#
# MTA module for "regular" Exim setup
#

package AMAVIS::MTA::Exim;
use strict;
use vars qw($VERSION);
$VERSION='0.1';

use AMAVIS;
use AMAVIS::Logging;
use IO::File;
use File::Path;

use File::Copy;
use Sys::Hostname;


use vars qw(
            $cfg_exim_binary
            $cfg_exim_args
            $cfg_x_header
            $cfg_x_header_tag
            $cfg_x_header_line
           );

sub init {
  my $self = shift;
  my $args = shift;
# does not work, so using the old-fashioned way:
#  $cfg_exim_binary = (($AMAVIS::cfg->val('Exim', 'exim') =~ s/[^\w]//g) || 
'/usr/sbin/exim');
#  $cfg_exim_args = (($AMAVIS::cfg->val('Exim', 'args') =~ s/[^\w]//g) || '-oMr 
no-scan -i -f');
  $cfg_exim_binary = $AMAVIS::cfg->val('Exim', 'exim');
  $cfg_exim_args = $AMAVIS::cfg->val('Exim', 'args');



  if (! -x $cfg_exim_binary) {
    writelog($args,LOG_CRIT, "$cfg_exim_binary not executable");
    return 0;
  }

  if (($AMAVIS::cfg->val('global', 'x-header') || '') eq 'true') {
    $cfg_x_header = 1
  };
  $cfg_x_header_tag = $AMAVIS::cfg->val('global', 'x-header-tag');
  $cfg_x_header_line = $AMAVIS::cfg->val('global', 'x-header-line');

  writelog($args,LOG_DEBUG,__PACKAGE__." initialized.");
  # Return successfully
  return 1;
}

sub cleanup {
  my $self = shift;
  my $args = shift;
  return 1;
}

# Create temp dir and write mail
sub get_directory {
  my $self = shift;
  my $args = shift;

  # Create temp directory. Try creating $prefix[date]-[pid] 
  # If unsuccessful after 10 tries, abort
  my $prefix = "$AMAVIS::cfg_unpack_dir/amavis-unpack-";
  my $i = 0;
  my $message_id;
  while (1) {
    $message_id = sprintf("%.8x-%.4x",time,$$);
    unless (defined mkpath ($prefix.$message_id, 0, 0770)) {
      if (++$i > 10) {
        return 0;
      }
      else {
        next;
      }
    }
    last;
  }
  $$args{'message_id'}=$message_id;
  my $directory = $prefix.$message_id;
  mkdir "$directory/parts", 0777;
  $$args{'directory'} = $directory;

  # Open message file that is later going to be disected and scanned
  my $output = IO::File->new("+>$directory/email.txt");

  # Get message from STDIN
  my $headers=1;
  $$args{'headers'}='';
  while (<STDIN>) {
    if (/^ *$/) {
      $headers=0;
    }
    if ($headers==1) {
      $$args{'headers'}.=$_;
    }
    print $output $_;
  }

  if ($#ARGV < 1) {
    writelog($args,LOG_ERR, __PACKAGE__.": Missing arguments to exim");
    return 0;
  }

  writelog($args,LOG_DEBUG, "Called as amavis ".join(' ',@ARGV));

  foreach (@ARGV) {
    /^-f$/ && next; # ignore "-f"
    /^-d$/ && next; # ignore "-d"
    /^(.*)$/; # untaint sender or recipient
    unless (defined $$args{'sender'}) {
      my $sender = $1;
      if ($sender =~ /^$/) {
        $sender= "<>";
      }
      writelog($args,LOG_DEBUG, "Sender: $sender");
      $$args{'sender'} = $sender;
    }
    else {
      my $recipient = $1;
      writelog($args,LOG_DEBUG, "Recipient: $recipient"); 
      push @{$$args{'recipients'}}, $recipient;
    }
  }

  # Message file has been written, reset file pointer and put it into
  # the record.
  $output->seek(0,0);
  $$args{'filehandle'} = $output;

  # Return successfully
  return 1;
}

# Generate a copy of the scanned message and pipe it to mailer.
sub accept_message {
  my $self = shift;
  my $args = shift;
  writelog($args,LOG_INFO, __PACKAGE__.": Accepting message");
  my @cfg_exim_args;

  push @cfg_exim_args, split(/\s+/,$cfg_exim_args);
  push @cfg_exim_args, $$args{'sender'};
  push @cfg_exim_args, @{$$args{'recipients'}};

  writelog($args,LOG_DEBUG, __PACKAGE__.": Running $cfg_exim_binary ".
           join(' ',@cfg_exim_args));

  open(MAIL, "|-") || exec($cfg_exim_binary, @cfg_exim_args);
  # Copy the original message headers.
  while (my $line=$$args{'filehandle'}->getline()) {
    last if ($line =~ /^ *$/);
    print MAIL $line;
  }
  # Insert our headers.
  if ($cfg_x_header) {
    print MAIL "$cfg_x_header_tag: $cfg_x_header_line\n";
  }
  # Print an empty line.
  print MAIL "\n";
  # Copy the original message body.
  while (my $line=$$args{'filehandle'}->getline()) {
    print MAIL $line;
  }
  close(MAIL);

  if ($? != 0) {
    writelog($args,LOG_ERR, __PACKAGE__.": $cfg_exim_binary exited with 
".($?>>8));
  }

  $$args{'status'} = 'accept';

  # Return successfully
  return 1;
}

# Just "forget" the mail.
sub drop_message {
  my $self = shift;
  my $args = shift;
  # Doing nothing should suffice
  writelog($args,LOG_WARNING, __PACKAGE__.": Dropping message");

  # Return successfully
  return 1;
}

sub freeze_message {
  my $self = shift;
  my $args = shift;
  writelog($args,LOG_WARNING, __PACKAGE__.": Freezing message");

  # Instead of freezing, drop the message, but store a copy in
  # $cfg_problem_dir -- analogous to AMAVIS::quarantine_message()
  if (AMAVIS->quarantine_problem_message($args)) {
    # Return successfully
    return 1;
  }
  else {
    writelog($args,LOG_ERR,__PACKAGE__.": Could not freeze message");
    return 0;
  }
}

# Called from Notify::*.pm, i.e. for sending warining messages
sub send_message {
  my $self = shift;
  my $args = shift;
  my $message = shift;
  my $sender = shift;
  my @recipients = @_;
  writelog($args,LOG_DEBUG, __PACKAGE__.": Sending mail from $sender to ".
           join(', ',@recipients));

  my @cfg_exim_args;

  push @cfg_exim_args, split(/\s+/,$cfg_exim_args);
  push @cfg_exim_args, $sender;
  push @cfg_exim_args, @recipients;

  writelog($args,LOG_DEBUG, __PACKAGE__.": Running $cfg_exim_binary ".
           join(' ',@cfg_exim_args));

  open(MAIL, "|-") || exec($cfg_exim_binary, @cfg_exim_args);
  print MAIL $message;
  close(MAIL);

  if ($? != 0) {
    writelog($args,LOG_ERR,
             __PACKAGE__.": $cfg_exim_binary @cfg_exim_args exited with 
".($?>>8));
  }

  # Return successfully
  return 1;
}

1;

--===============0306671289==--


---------------------------------------
Received: (at 290456-close) by bugs.debian.org; 14 Jan 2005 19:06:50 +0000
>From [EMAIL PROTECTED] Fri Jan 14 11:06:50 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1CpWmY-0001dx-00; Fri, 14 Jan 2005 11:06:50 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
        id 1CpWhy-0007hX-00; Fri, 14 Jan 2005 14:02:06 -0500
From: Stefan Hornburg (Racke) <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#290456: fixed in amavis-ng 0.1.6.9-1
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Fri, 14 Jan 2005 14:02:06 -0500
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: amavis-ng
Source-Version: 0.1.6.9-1

We believe that the bug you reported is fixed in the latest version of
amavis-ng, which is due to be installed in the Debian FTP archive:

amavis-ng-milter-helper_0.1.6.9-1_i386.deb
  to pool/main/a/amavis-ng/amavis-ng-milter-helper_0.1.6.9-1_i386.deb
amavis-ng_0.1.6.9-1.diff.gz
  to pool/main/a/amavis-ng/amavis-ng_0.1.6.9-1.diff.gz
amavis-ng_0.1.6.9-1.dsc
  to pool/main/a/amavis-ng/amavis-ng_0.1.6.9-1.dsc
amavis-ng_0.1.6.9-1_all.deb
  to pool/main/a/amavis-ng/amavis-ng_0.1.6.9-1_all.deb
amavis-ng_0.1.6.9.orig.tar.gz
  to pool/main/a/amavis-ng/amavis-ng_0.1.6.9.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stefan Hornburg (Racke) <[EMAIL PROTECTED]> (supplier of updated amavis-ng 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 14 Jan 2005 19:26:35 +0100
Source: amavis-ng
Binary: amavis-ng-milter-helper amavis-ng
Architecture: source all i386
Version: 0.1.6.9-1
Distribution: unstable
Urgency: low
Maintainer: Stefan Hornburg (Racke) <[EMAIL PROTECTED]>
Changed-By: Stefan Hornburg (Racke) <[EMAIL PROTECTED]>
Description: 
 amavis-ng  - AMaViS "Next Generation"
 amavis-ng-milter-helper - AMaViS "Next Generation" helper program for Milter
Closes: 290456
Changes: 
 amavis-ng (0.1.6.9-1) unstable; urgency=low
 .
   * new upstream release:
     - fixed broken Exim MTA module (Closes: #290456, thanks to Sebastian
       Bleikamp <[EMAIL PROTECTED]> for the report)
Files: 
 4a48067088af93a22dc856b2dd87276c 641 admin optional amavis-ng_0.1.6.9-1.dsc
 ecb3e6e7fd7ec9077e81e95f29284e63 270836 admin optional 
amavis-ng_0.1.6.9.orig.tar.gz
 bd106074a5583d025152d45689338e90 2541 admin optional 
amavis-ng_0.1.6.9-1.diff.gz
 2f5f3cb1895ebe1bf3f8fcf05e987cc2 84118 admin optional 
amavis-ng_0.1.6.9-1_all.deb
 036c870ac49b1e80e8eaf16451efeede 25158 admin optional 
amavis-ng-milter-helper_0.1.6.9-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFB6BJFjgVfE5tya3ERAmeVAJ0SIvi/wRzBZFwKV0cA3LXUBcSIvwCg0de5
CubSU20/Yt91F25ulLAznBk=
=Kc1m
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to