Your message dated Fri, 23 Apr 2010 00:11:41 +0200
with message-id <20100422221141.gn15...@nan92-1-81-57-214-146.fbx.proxad.net>
has caused the report #578773,
regarding gcompris: superbrain gave two blacks and a white with only three pegs
in level 1
to be marked as having been forwarded to the upstream software
author(s) Bruno Coudoin <bruno.coud...@free.fr>
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
578773: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578773
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Hi Bruno,
Here is a bugfix you may like.
cu,
--
Yann
--- Begin Message ---
tags 578773 patch
thanks
On Thu, Apr 22, 2010 at 07:04:51PM +0300, Julian Gilbey wrote:
> Package: gcompris
> Version: 9.2-2-1
> Severity: normal
>
> Fascinating problem: the correct sequence was something like
> red-cyan-green. With the input red-blue-green, the computer put a
> black around the red and green and a white around the blue.
Found the bug - it was an array overflow/off-by-one error. Here is a
patch (the file is src/superbrain-activity/superbrain.c):
--- superbrain.c.orig 2010-04-22 20:14:39.000000000 +0300
+++ superbrain.c 2010-04-22 20:15:10.000000000 +0300
@@ -558,7 +558,7 @@
g_object_set (piece->misplaced, "visibility",
GOO_CANVAS_ITEM_VISIBLE, NULL);
done = TRUE;
}
- } while (!done && j++!=number_of_piece);
+ } while (!done && ++j!=number_of_piece);
}
/* Display the matermind information to the user */
Julian
--- End Message ---
--- End Message ---
