Bug#545970: marked as forwarded (nis: FTBFS on GNU/kFreeBSD (network-manager is linux specific))

[Debian Bug Tracking System]

Your message dated Wed, 23 Sep 2009 18:03:21 +0100
with message-id <20090923170320.ga3...@sirena.org.uk>
has caused the   report #545970,
regarding nis: FTBFS on GNU/kFreeBSD (network-manager is linux specific)
to be marked as having been forwarded to the upstream software
author(s) ku...@linux-nis.org

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
545970: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=545970
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

--- Begin Message ---

The enclosed patch was submitted against the Debian NIS package - it
adds configure magic to disable the NM integration on FreeBSD (where NM
isn't implemented yet) for the Debian/kFreeBSD port.

--- Begin Message ---

It is usually upstream decision whether some "Optional Feature"
have default "yes", "no" or "auto".
In this case upstream uses "yes", not "auto".

So please submit a patch changing that.  Consider, for example, making
the decision conditional on the OS if you're concerned about this but
are you sure upstream has even considered the options here?

I'd be willing to take a patch such as I've been asking for which means
that I don't need to pay attention to missing components on FreeBSD.

Another version of patch is attached. After applying please perform

  cd ypbind-mt-1.20.1/
  autoconf

to regenerate ypbind-mt-1.20.1/configure.

Petr

diff -u nis-3.17/debian/control nis-3.17/debian/control
--- nis-3.17/debian/control
+++ nis-3.17/debian/control
@@ -4,7 +4,9 @@
 Maintainer: Mark Brown <broo...@debian.org>
 Uploaders: Miquel van Smoorenburg <miqu...@cistron.nl>
 Standards-Version: 3.8.1
-Build-Depends: libgdbm-dev, gcc (>= 2.95), gettext, po-debconf, libslp-dev, libdbus-glib-1-dev, network-manager-dev, file
+Build-Depends: libgdbm-dev, gcc (>= 2.95), gettext, po-debconf, libslp-dev, file,
+ libdbus-glib-1-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
+ network-manager-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386]
 Vcs-Bzr: http://bzr.debian.org/bzr/pkg-nis/nis/debian/
 
 Package: nis
only in patch2:
unchanged:
--- nis-3.17.orig/ypbind-mt-1.20.1/configure.in
+++ nis-3.17/ypbind-mt-1.20.1/configure.in
@@ -51,6 +51,18 @@
 
 AC_ARG_ENABLE([dbus-nm],
    AC_HELP_STRING([--disable-dbus-nm],[Disable DBUS/NetworkManager support]))
+
+case "$host_os" in
+	linux*)
+	;;
+	*)
+	if test "$enable_dbus_nm" \!= "yes" 
+	then
+		enable_dbus_nm=no
+	fi
+	;;
+esac
+
 if test "$enable_dbus_nm" \!= "no"
 then
   PKG_CHECK_MODULES(DBUS, dbus-glib-1 >= 0.60)
@@ -112,7 +124,7 @@
     echo "***"
     echo "***"
     ;;
-  linux*)
+  linux*|kfreebsd*-gnu*)
     dnl send a ping to all server at the same time:
     USE_BROADCAST=1
     dnl Test, if we have glibc 2.0 or glibc 2.1
only in patch2:
unchanged:
--- nis-3.17.orig/ypbind-mt-1.20.1/src/ypbind-mt.c
+++ nis-3.17/ypbind-mt-1.20.1/src/ypbind-mt.c
@@ -875,8 +875,11 @@
       portmapper_disconnect ();
       exit (1);
     }
+
+#ifdef USE_DBUS_NM
   if (!is_online)
     portmapper_disconnect ();
+#endif
 
   pthread_create (&ping_thread, NULL, &test_bindings, NULL);
 

--- End Message ---

--- End Message ---