Your message dated Mon, 12 Nov 2007 12:10:30 +0000
with message-id <[EMAIL PROTECTED]>
has caused the Debian Bug report #414784,
regarding puttygen: requires a final newline
to be marked as having been forwarded to the upstream software
author(s) [EMAIL PROTECTED]
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Any comments on this patch? It's a little odd to run fgetc again on EOF,
and perhaps 'if (c != EOF) c = fgetc(fp);' would be better, but it
should work anyway.
For the benefit of the PuTTY list, the original bug report was that
puttygen refuses to extract a key unless the key file ends with a
carriage return or a newline:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=414784
Thanks,
--
Colin Watson [EMAIL PROTECTED]
----- Forwarded message from Justin Pryzby <[EMAIL PROTECTED]> -----
X-Spam-Checker-Version: SpamAssassin 3.1.4-bugs.debian.org_2005_01_02
(2006-07-26) on rietz.debian.org
X-Spam-Status: No, score=-4.9 required=4.0 tests=BAYES_00,FOURLA,
MURPHY_DRUGS_REL8,VALID_BTS_CONTROL autolearn=no
version=3.1.4-bugs.debian.org_2005_01_02
Date: Tue, 30 Oct 2007 13:08:24 -0400
From: Justin Pryzby <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Subject: putty-tools: [PUTTYGEN] [PATCH] requires a final newline
User-Agent: Mutt/1.5.16 (2007-06-11)
user [EMAIL PROTECTED]
usertag 414784 puttygen
tag 414784 patch
thanks
--- putty-0.60.orig/sshpubk.c
+++ putty-0.60/sshpubk.c
@@ -495,16 +495,12 @@
while (1) {
c = fgetc(fp);
- if (c == '\r' || c == '\n') {
+ if (c == '\r' || c == '\n' || c == EOF) {
c = fgetc(fp);
if (c != '\r' && c != '\n' && c != EOF)
ungetc(c, fp);
return text;
}
- if (c == EOF) {
- sfree(text);
- return NULL;
- }
if (len + 1 >= size) {
size += 128;
text = sresize(text, size, char);
--- putty-0.60.orig/sshpubk.c
+++ putty-0.60/sshpubk.c
@@ -495,16 +495,12 @@
while (1) {
c = fgetc(fp);
- if (c == '\r' || c == '\n') {
+ if (c == '\r' || c == '\n' || c == EOF) {
c = fgetc(fp);
if (c != '\r' && c != '\n' && c != EOF)
ungetc(c, fp);
return text;
}
- if (c == EOF) {
- sfree(text);
- return NULL;
- }
if (len + 1 >= size) {
size += 128;
text = sresize(text, size, char);
----- End forwarded message -----
--- End Message ---
