Dear Maintainer,

The hardening flags are missing for mkFileSum.c because the build
system doesn't use them.

The attached patch fixes the issue - but I'm not sure if it's the
best way, I have no idea why the build system use BUILD_*FLAGS
variables instead of just *FLAGS. If possible it should be sent
upstream (maybe in modified form).

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
Description: Use (hardening) build flags from environment (dpkg-buildflags).
 The BUILD_*FLAGS are not set to same values as *FLAGS and only used in this
 Makefile.
 .
 Necessary for hardening flags.
Author: Simon Ruderich <si...@ruderich.org>
Last-Update: 2012-03-12

--- amule-2.3.1.orig/src/libs/ec/cpp/Makefile.in
+++ amule-2.3.1/src/libs/ec/cpp/Makefile.in
@@ -623,7 +623,7 @@ uninstall-am:
 
 
 mkFileSum$(BUILD_EXEEXT): $(top_srcdir)/src/utils/mkFileSum.c
-	$(BUILD_CC) $(BUILD_CFLAGS) $(BUILD_CPPFLAGS) $(BUILD_LDFLAGS) $^ -o $@
+	$(BUILD_CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $^ -o $@
 
 ECVersion.h: EC-timestamp
 	@if test ! -f $@; then \
--- amule-2.3.1.orig/src/libs/ec/cpp/Makefile.am
+++ amule-2.3.1/src/libs/ec/cpp/Makefile.am
@@ -35,7 +35,7 @@ BUILT_SOURCES = ECVersion.h
 CLEANFILES = ECVersion.h EC-timestamp mkFileSum$(BUILD_EXEEXT)
 
 mkFileSum$(BUILD_EXEEXT): $(top_srcdir)/src/utils/mkFileSum.c
-	$(BUILD_CC) $(BUILD_CFLAGS) $(BUILD_CPPFLAGS) $(BUILD_LDFLAGS) $^ -o $@
+	$(BUILD_CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $^ -o $@
 
 ECVersion.h: EC-timestamp
 	@if test ! -f $@; then \

Attachment: pgpAH0H2oGEoh.pgp
Description: PGP signature

Reply via email to