tags 299658 + patch
thanks

This bug is caused by failing to increment an offset variable (used to
detect EOF) in quiet and silent mode.  Further, whether the affected
code is run depends on block size, redundancy level, memory limit and
input file size, so the bug is not always triggered.  File sizes above a
few hundred megs typically crash the program but small files don't.

This has also been reported upstream:
http://sourceforge.net/tracker/index.php?func=detail&aid=1085638&group_id=30568&atid=399698

I'm submitting the following trivial fix here as upstream seems to be
inactive at the moment.

Cheers,
Stelios Bounanos <sb()enotty()net>


diff -Nuar par2cmdline-0.4.orig/par2creatorsourcefile.cpp 
par2cmdline-0.4/par2creatorsourcefile.cpp
--- par2cmdline-0.4.orig/par2creatorsourcefile.cpp      2004-04-15 
14:45:23.000000000 +0100
+++ par2cmdline-0.4/par2creatorsourcefile.cpp   2005-09-29 02:27:43.000000000 
+0100
@@ -213,11 +213,12 @@
         }
       }
 
+      offset += want;
+
       if (noiselevel > CommandLine::nlQuiet)
       {
         // Display progress
         u32 oldfraction = (u32)(1000 * offset / filesize);
-        offset += want;
         u32 newfraction = (u32)(1000 * offset / filesize);
         if (oldfraction != newfraction)
         {


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to