Hi Benoît,
thank you again for these notices.
Il 06/03/2012 23:25, Benoît Knecht ha scritto:
> Giulio Paci wrote:
>> thank you for your comment. I updated the package, adding the missing
>> libxslt1-dev dependency and fixing a couple of other minor issues.
>
> A few things to look into:
>
> - Your man page is quite thin. Please expand it using full words
> instead of abbreviations (img, thumb, etc.) and full sentences. Try
> explaining what each option does.
>
> For instance, '-o' takes a path as an argument; to what, a directory
> or a file? What happens if both and XML file and a thumbnail are to
> be generated?
>
> Likewise, the description of '-s' doesn't help me at all. What is
> the range of the threshold? Is it a float or an integer? What does
> it represent?
>
> For '-w', what is a waveform?
>
> You also need to escape the space between 'January,' and '2012'.
I fixed the man page as much as I was able of the issue above.
I think that now the man page is much more useful.
> - debian/patches/compilation_fixes.patch contains a lot of whitespace
> fixes, most of them in comments; please remove those to make it
> easier to understand.
Now the changes are only those that are really necessary (I am not
removing trailing spaces anymore).
> - Why are you putting your package in contrib/misc? As far as I can
> see, it doesn't depend on a non-free package, so the video section
> seems more appropriate.
You are right. I also changed the section to video.
> - ltmain.sh is GPL-2+, and the FSF is its copyright holder; this
> should be reflected in debian/copyright. Use
>
> licensecheck -r --copyright .
>
> to make sure you're not missing anything else.
Thank you for the hint. I think that all the files have their copyright
and license correctly reported now.
> - I don't think you should install AUTHORS; it contains a single name,
> and that information is in debian/copyright already.
>
> The NEWS file seems pretty useless as well.
>
> The README file is just plain confusing.
Those files are not installed anymore.
I just re-uploaded the package here:
http://mentors.debian.net/debian/pool/contrib/s/shotdetect/shotdetect_1.0.86-1.dsc
Cheers,
Giulio.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
