The proposed patch is wrong: as written it arranges to reject filenames
that begin with ".core", rather than those that end with ".core". Files
whose names end ".core" are already rejected by cfgfile_filter(), and
files whose names begin ".core" are rejected by the general rejection of
filenames beginning with ".".
I think the original test is intended to trap old-style core dumps, which
are always called simply "core". This could be correctly achieved by:
--- insserv.c.orig 2010-02-19 13:08:04.000000000 +0000
+++ insserv.c 2012-02-27 12:10:01.000000000 +0000
@@ -2764,7 +2764,7 @@
continue;
}
- if (!strncmp(d->d_name, "core", strlen("core"))) {
+ if (!strcmp(d->d_name, "core")) {
if (isarg)
warn("script name %s is not valid, skipped!\n", d->d_name);
continue;
--
Ben Harris, University of Cambridge Computing Service.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
