On 2012-02-26 09:32, Adam D. Barratt wrote:
| On Sun, 2012-02-26 at 11:28 +0200, jaalto wrote:
| > On 2012-02-26 09:20, Adam D. Barratt wrote:
| > | fwiw, it breaks even if you remember to use the right variable in the
| > | second example... ;-)
| > | 
| > | $ foo=/etc/ld.so.conf; echo "$(head -n 1 \"$foo\")"
| > | head: cannot open `"/etc/ld.so.conf"' for reading: No such file or 
directory
| > 
| > One of the benfits of POSIX command substitution is also, that there
| > is no need for extra quoting:
| 
| You're missing James's point, though.  You provided a patch which broke
| the script and therefore obviously hadn't been tested. 

Yes, I missed those spots, Thank you. I was about to revise the patch
according to the comments, but then the bug was closed.

| That also demonstrated that the change isn't as trivial and simply
| aesthetic as claimed.

That's true, and it's good that there were comments to bring this to
mo my attention to remember to check also those.

I still feel that the use of POSIX $() would improve readability.

Jari





-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to