-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Sun, Feb 19, 2012 at 10:39:40PM -0500, Ted Ts'o wrote:
> I don't understand, but it looks like the hardening flags are being
> passed, but either (a) they are't correct, or (b) they seemingly have
> no effect.  Can you help me?  What have I missed?

The hardening flags in the build log you posted are correct - and
have an effect in your local build.

But I think I found the source of the problem, the problem is the
redirection syntax you use:

    dpkg-buildflags >& /dev/null

Dash, which is (now) the default shell for scripts on Debian,
doesn't support that - and it's used by the buildds I think. I
guess you have bash as your /bin/sh which accepts that syntax.

The following works fine:

    dpkg-buildflags > /dev/null 2>&1

And fixes the hardening flags for me.

But you don't need to check if dpkg-buildflags is available. You
could use the method I suggested in the last message and call
dpkg-buildflags unconditionally - if it doesn't exist no output
is added to the *FLAGS variables.

Btw. I think there's one problem with the current debian/rules:
If dpkg-buildflags is found and used then
- -Wl,-Bsymbolic-functions is missing from LDFLAGS, I'm not sure if
this was intended.

Regards,
Simon
- -- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJPQq0BAAoJEJL+/bfkTDL50DQQAIz7QMZHv6l6+yCwdrrDdUuG
GIP2ZfGIGEgYZlMZdHs4/Eb75QHxAPD0zbqTHxDja1r/wktYFnH1VH3wdVhZuZC4
5Rcf7um8o6RuK99lorlcN1LlN7yxIUNPFIYn8haKKJwMkg250v8lli5aRz0wiqYM
dP4H79GfZoD0JFyeDapQiHM/8hPD3BLImCp8qfYeugjhOUwDWWoV2BlpVXTgxcq2
3pBcf1xgJp5iZ5r4krF1D7YIT1gjilMxXH8b+8MKI+HP+W7fDRcUCeHPgq/mOq5v
1hoaCQ6gFxNG/pN0H7yANmDdb9PGwKPHhGYO9aVda4U8IT4kK8+alCoyjq72jQvc
Q5S1BDtNrvAMBa8II2alGY+g94UJi6313luF9eQx4pGHDGVFuWxXkBIxNbqwyLD3
DPSFKL/MybtMttoyCfhsDRA1L1/c4TYmDW/umA5uA3MzyjoZxCzu1L8ETAIU/2b8
Y5l8aD7LMmkG04hHe0kjMgjAtL9/pdKSUByLmiI3lPQx0/JgHrt6BhmZspoJaR3h
AbMHbSM1QuhBbPFHhpx3mHOI0Pmczoxp438TUfNku3BRqc7O+Ga20lmcV7JYJLNk
dDs7M1iZoh1WhHDclMCwNjFwn1/mSDMPZ5idGdTPyGOEXOmcdcrJRjfynaaLys6F
mnoq9pQRjPuCbp6SfPAU
=MUTy
-----END PGP SIGNATURE-----



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to