tag 597789 + patch
thanks

On Thu, Sep 23, 2010 at 01:38:53AM +0200, Eckhart Wörner wrote:
> osynctool --configure seems to have vi hardcoded.
> 
> Section 11.4 of the Debian Policy Manual states that "every program
> that launches an editor or pager must use the EDITOR or PAGER
> environment variable to determine the editor or pager the user wishes
> to use. If these variables are not set, the programs /usr/bin/editor
> and /usr/bin/pager should be used, respectively."

The code actually does honor the EDITOR environment variable. If empty,
it does indeed call vi unconditionally, though. Attached trivial patch
should fix it.

Hauke

-- 
 .''`.   Jan Hauke Rahm <j...@debian.org>               www.jhr-online.de
: :'  :  Debian Developer                                 www.debian.org
`. `'`   Member of the Linux Foundation                    www.linux.com
  `-     Fellow of the Free Software Foundation Europe      www.fsfe.org
--- osynctool-0.39.orig/tools/osynctool.c
+++ osynctool-0.39/tools/osynctool.c
@@ -1071,7 +1071,7 @@
        if (editor)
                editcmd = g_strdup_printf("%s %s", editor, tmpfile);
        else
-               editcmd = g_strdup_printf("vi %s", tmpfile);
+               editcmd = g_strdup_printf("/usr/bin/editor %s", tmpfile);
 #endif

        if (system(editcmd)) {

Attachment: signature.asc
Description: Digital signature

Reply via email to