Hi Micha, Sorry for delay.
On Mon, 23 Jan 2012 19:22:29 Micha Lenk wrote: > > Description: customizable taxinvoice > > > > Original taxinvoice template lacks flexibility necessary to make > > legaly valid Australian Tax Invoices. > > This patch introduces customization options > > useful to comply with Australian requirements, but not limited to. > > > > * Hardcoded messages in English are replaced with options and defaults > > > > matching original report. This makes possible report localization. > > > > * Added options to change report presentation and embed CSS. > > * Fixed bug when customer's name in billing address is listed twice. > > All three of these changes should go into separate patches. The reason > is, that this way it is simpler to discuss them separately with > upstream. Imagine the *very unlikely* event that upstream doesn't like > the new options (why ever), then they would have only the option to > reject the entire patch. With separate patches they could still accept > at least the bug fix. Additionally having small patches helps to better > understand the purpose of every single patch chunk. > You are right and this is a good suggestion. Thank you. However I have few concerns: Most important one is the time - I thought it can be done in few hours but it looks like I need a couple of days to do it. Unfortunately I can hardly afford to pay such toll on my time at the moment. On second thought splitting patch into three won't make as much difference because patches would be stacked on top of each other so rejecting just one of them would require to make at least some work once again. Worst case if first patch would be rejected - in this case there will be no difference at all. Upstream may suggest some changes so I prepared to alter the template again anyway. I'll see what I can do. If everything goes well I will send splitted patches. Meanwhile do you think it might worth to introduce patch before refactoring it? Cheers, Dmitry.
signature.asc
Description: This is a digitally signed message part.
