On Thu, 2012-01-26 at 22:19 +0100, Magnus Holmgren wrote: > On tisdagen den 24 januari 2012, you stated the following: > > This patch solves the build problems for GNU/Hurd due to MAXPATHLEN > > issues. The solution is to make dynamic string allocations instead of > > using fixed length buffers. The functions mkdirhier, basename and > > dirname have all been checked with separate test programs on Linux and > > Hurd and with valgrind on Linux without problems. Furthermore, parts of > > the the code has been reviewed by GN/Hurd developers and Debian GNU/Hurd > > developers and maintainers. > > Thanks! I've been thinking of doing something about this myself but there > were > so many instances of MAXPATHLEN that I got tired before I got started. :-)
Yes, I realized that too, but after starting with the compat functions and mkdirhier things went on. > > Build and run tested on both Linux and Hurd without problems. Also heap > > and leak tested on Linux with valgrind. No heap errors, but still memory > > leaks (coming from the original code). Removing the memory leaks will > > need another deep investigation of the original code, which time does > > not permit right now. > > Leaks other than the ones in th_get_pathname()? Don't remember right now. I can run valgrind again if you are interested. > > Since there is no upstream, the wish is that the Debian Maintainer > > takes a look at this patch and checks if it can be applied. Test > > programs are available on request. This patch will affect all > > architectures, completely removing the MAXPATHLEN dependencies (except > > for a few unused compat functions). > > I'll have a look and forward it to the libtar mailing list. There actually is > sort of an official unofficial upstream at http://repo.or.cz/w/libtar.git > since a while back. Good to know about this repo. Regarding mailing list the link https://lists.feep.net:8080/mailman/listinfo.cgi/libtar times out all the time for me. Is another mailing list used? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
