Hello Otavio, hello Jeremy,

Otavio Salvador [2012-01-09 15:27 -0200]:
> If you can look at other changes he has proposed and import what you think
> is OK (I didn't check the .pc changes you referred to) I am OK in review
> and upload it to experimental.

I pushed a commit to fix the version number (1.0~beta5, not 1.0-beta5,
that'll cause trouble when we want to release 1.0-1), and reviewed
Jean-Louis' debdiff.

 * We do not need debian/freerdp.pc, we can (and should) just use the
   one generated by the upstream build.

 * Jean-Louis added the libavcodec-dev build dependency, and indeed
   the cmake build system files check for this. Committed.

 * The rest of Jean-Louis' diff is applied.

 * As the symbols file shows, the ABI totally changed. This needs
   bumping the SONAME of libfreerdp0, which should happen upstream.
   Now, Debian and Ubuntu just have one reverse dependency
   (remmina-plugin-rdp), so if upstream does not want to bump for some
   reason, we could deal with it, but it'd be ugly.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Attachment: signature.asc
Description: Digital signature

Reply via email to