> From: Rob Browning <r...@defaultvalue.org> > Cc: 10...@debbugs.gnu.org, 655...@bugs.debian.org, > 655118-forwar...@bugs.debian.org, j...@inutil.org > Date: Tue, 24 Jan 2012 20:22:52 -0600 > > Eli Zaretskii <e...@gnu.org> writes: > > > I think the right fix for this is to declare `error' with the > > appropriate printf attribute. Alternatively, you could use variable > > argument lists and call vprintf instead. > > Would something like this be acceptable, and if not, how would you like > to see it adjusted? The patch changes error() to use an ANSI > declaration, and it relies on the printf format attribute:
This is fine with me, but please use ATTRIBUTE_FORMAT_PRINTF (defined in src/config.h) instead of a literal __attribute__(...), which is a GCC-only thing. Thanks. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
