Source: proftpd-dfsg
Severity: important
Tags: patch

Please enabled hardened build flags through dpkg-buildflags.

Patch attached. (dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS)

Cheers,
        Moritz
diff -aur proftpd-dfsg-1.3.4a.harden/debian/rules proftpd-dfsg-1.3.4a/debian/rules
--- proftpd-dfsg-1.3.4a.harden/debian/rules	2011-11-21 13:30:16.000000000 +0100
+++ proftpd-dfsg-1.3.4a/debian/rules	2012-01-24 21:59:02.000000000 +0100
@@ -12,26 +12,19 @@
 PROFTPD_FLAGS := -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_OPENSSL -DUSE_LDAP_TLS
 CFLAGS := $(PROFTPD_FLAGS) 
 CC := gcc
-OPTFLAG = -O2
 
 # Some special build options
 ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
   DEVELOPT=--enable-devel=yes
-  OPTFLAG = -O0
 endif
 ifneq (,$(findstring verbose,$(DEB_BUILD_OPTIONS)))
 DH_VERBOSE=1
 export DH_VERBOSE
 endif
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
-  OPTFLAG = -O0 
-endif
 ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
   INSTALL_STRIP=-s
 endif
 
-CFLAGS += $(OPTFLAG)
-
 #
 # dpkg-arch rules
 # 
@@ -66,7 +59,7 @@
 build-stamp: 
 	dh_testdir
 	
-	$(MAKE) CC="$(CC)" CFLAGS="$(CFLAGS)" all
+	$(MAKE) CC="$(CC)" all
 	
 	touch $@
 
@@ -90,7 +83,7 @@
 		mv ./config.guess ./config.guess.original && \
 		cp -f /usr/share/misc/config.guess ./config.guess
 	
-	./configure $(CONF_ARGS) --with-shared=$(DSOMODS1)$(DSOMODS2)$(DSOMODS3)$(DSOMODS4)
+	./configure $(shell dpkg-buildflags --export=configure) $(CONF_ARGS) --with-shared=$(DSOMODS1)$(DSOMODS2)$(DSOMODS3)$(DSOMODS4)
 	
 	touch $@
 
Nur in proftpd-dfsg-1.3.4a/debian: rules~.

Reply via email to