Am 23/01/12 16:16, schrieb Svante Signell:
Hello Jelmer,
On Mon, 2012-01-23 at 15:19 +0100, Jelmer Vernooij wrote:
Hi Svante,
The following tiny patch below enables a successful build of tdb for
GNU/Hurd. Since IOV_MAX is not defined for Hurd there is no reason to
check it's value.
Thanks for the patch.
I don't really understand it though. This is code that deals with the
case where IOV_MAX is not defined (as is the case for hurd); it doesn't
check for the value of IOV_MAX, it defines it.
Can you elaborate on why this is necessary?
If IOV_MAX is not defined, the build fails with an error. The proposed
change prevents that check so that IOV_MAX remains undefined.
What's the exact build failure ?
The original code uses "#ifndef IOV_MAX" to see if it should define
IOV_MAX. I don't see why that would fail if IOV_MAX isnt actually defined.
Cheers,
Jelmer
Complete function below:
#if !defined IOV_MAX&& !defined __GNU__
# ifdef UIO_MAXIOV
# define IOV_MAX UIO_MAXIOV
# else
# ifdef __sgi
/*
* IRIX 6.5 has sysconf(_SC_IOV_MAX)
* which might return 512 or bigger
*/
# define IOV_MAX 512
# else
# error IOV_MAX and UIO_MAXIOV undefined
# endif
# endif
#endif
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
