Package: apt-build
Version: 0.12.11
Severity: important
Tags: patch

Hello,

When I try to build a package with a patch using apt-build, it does not work.
It applies the patch, but than concludes it failed to apply (though it
applied correctly) and does debclean and aborts.

I traced the problem down to the sub patch, that properly return 0 if the
patch fails to apply, but then it does not return 1 when all the patches are
done. The following simple patch fixes is:

diff -ur apt-build-0.12.11.orig/apt-build apt-build-0.12.11/apt-build
--- apt-build-0.12.11.orig/apt-build    2005-09-17 16:35:54.000000000 +0200
+++ apt-build-0.12.11/apt-build 2005-09-24 17:15:04.000000000 +0200
@@ -40,7 +40,7 @@
 
 
 # Initial
-my $VERSION = "unreleased";
+my $VERSION = "0.12.11";
 my ($conf, %conf, @builddep, @apt_args);
 
 @apt_args = qw/--yes/;     # and DEFAULT => 1, down in parse_config()
@@ -139,6 +139,7 @@
 {
        print STDERR "-----> Patching (@_) <-----";
        !system "patch -p$conf{patch_strip} < $_" or return !$? while $_ = 
shift;
+       return 1;
 }
 
 sub clean_build

Regards,

                                                 Jan 'Bulb' Hudec <[EMAIL 
PROTECTED]>

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.12-1-amd64-k8
Locale: LANG=C, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)

Versions of packages apt-build depends on:
ii  apt                           0.6.41     Advanced front-end for dpkg
ii  apt-utils                     0.6.41     APT utility programs
ii  debconf                       1.4.58     Debian configuration management sy
ii  devscripts                    2.9.7      Scripts to make the life of a Debi
ii  dpkg-dev                      1.13.11    package building tools for Debian
ii  g++                           4:4.0.1-3  The GNU C++ compiler
ii  gcc                           4:4.0.1-3  The GNU C compiler
ii  libappconfig-perl             1.56-2     Perl module for configuration file
ii  libapt-pkg-perl               0.1.17     Perl interface to libapt-pkg
ii  perl                          5.8.7-5    Larry Wall's Practical Extraction 

Versions of packages apt-build recommends:
ii  build-essential               11.1       informational list of build-essent
ii  fakeroot                      1.5.1      Gives a fake root environment

-- debconf information:
  apt-build/arch_amd: k6
  apt-build/arch_alpha: ev4
* apt-build/options:
  apt-build/arch_intel: pentium
  apt-build/arch_arm: armv2
* apt-build/make_options:
* apt-build/olevel: Medium
* apt-build/build_dir: /var/cache/apt-build/build
* apt-build/repository_dir: /var/cache/apt-build/repository
  apt-build/arch_sparc: sparc
* apt-build/arch_amd64: athlon64
* apt-build/add_to_sourceslist: true

Attachment: signature.asc
Description: Digital signature

Reply via email to