On Fri, Jan 13, 2012 at 12:15 AM, Julien Cristau <jcris...@debian.org> wrote:
> On Tue, Jan 3, 2012 at 22:49:33 +0400, Sergei Golovan wrote:
>> ++ bn_rand = BN_new();
>> ++ if (! bn_rand ) {
>> ++ return enif_make_badarg(env);
>
> badarg seems a bit weird here, it's got nothing to do with its args?
It's a copy&paste from https://github.com/erlang/otp/commit/f228601de45c5
The behavior is the same as in the current Erlang versions (14.b.4 in
wheezy, 15.b in sid).
>> + -export([irandom/1, irandom/3]).
>> +--export([random/1, random/3]).
>> ++-export([random/1]).
>> + -export([xor_bits/2, fill_bits/2]).
>> + -export([i2bin/2, bin2i/1]).
>> +
>
> Am I reading this right that random/3 gets unexported? Is this safe
> (i.e. are you sure this was always unused)?
Yes, random/3 was never called outside ssh_bits module. The patch not
only unexports it but also removes it completely.
--
Sergei Golovan
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
