On Sun, Jan 08, 2012 at 08:01:58PM +0100, Josip Rodin wrote:
> On Sun, Jan 08, 2012 at 07:30:34PM +0100, Moritz Muehlenhoff wrote:
> > Package: maildrop
> > Version: 2.2.0-3.1
> > Severity: important
> > Tags: patch
> >
> > Please enable hardened build flags for your package. Since your
> > package has already been converted to dh, setting debian/compat
> > to 9 activates injecting the new default build flags.
> >
> > Patch attached.
>
> > --- maildrop-2.2.0.orig/debian/rules 2012-01-08 19:22:00.000000000
> > +0100
> > +++ maildrop-2.2.0/debian/rules 2012-01-08 19:22:52.000000000 +0100
> > @@ -1,12 +1,5 @@
> > #!/usr/bin/make -f
> >
> > -CFLAGS = -g
> > -CXXFLAGS = -g
> > -ifneq "$(shell dpkg-architecture -qDEB_HOST_ARCH)" "arm"
> > - CFLAGS += -O2
> > - CXXFLAGS += -O2
> > -endif
>
> And you would be reverting this because...?
Because dpkg-buildflags emits these by default and compat level 9 injects
them into the build system:
jmm@pisco:~$ dpkg-buildflags
CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Wformat-security -Werror=format-security
CPPFLAGS=-D_FORTIFY_SOURCE=2
CXXFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Wformat-security -Werror=format-security
FFLAGS=-g -O2
LDFLAGS=-Wl,-z,relro
jmm@pisco:~$
Cheers,
Moritz
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
