On Tue, Dec 20, 2011 at 08:19:38PM +0000, Dominic Hargreaves wrote: > On Sat, Dec 17, 2011 at 09:28:17AM +0200, Niko Tyni wrote: > > On Wed, Dec 14, 2011 at 11:30:54PM +0200, Niko Tyni wrote:
> > > My limited understanding is that the CV pointer needs its refcount > > > incremented along with the GvCV_set() call. See the attached proposed > > > patch which fixes this for me (but feel free to tell me if I got it all > > > wrong :) > > > > Here's another patch in a similar vein. This fixes all the remaining 24 > > warnings in t/logs/error_log after running the whole test suite. > > Incidentally it doesn't look like either of those messages made it > as far as the modperl dev list, at least if > > <http://mail-archives.apache.org/mod_mbox/perl-dev/201112.mbox/browser> > > is to be believed. I see. Hmph. I guess I'll have to try something else, probably the modp...@perl.apache.org list. Thanks for noticing this. > If it fixes the (extensive) test suite, it's probably a reasonable > candidate for an upload to unstable, I'd have thought? The test suite passes with the changes, yes, but I'm not really sure if I'm introducing a memory leak by fixing the reference counts in a wrong way. But yeah, it's probably good enough to try out in unstable. -- Niko Tyni nt...@debian.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
