It would seem the 'chmod' command needs to be replaced with a 'chown'.
Please find attached a series of 4 patch proposals that attempt to provide
a better solution to this bug as well as a few other small improvements.
[PATCH 1/4] Remove end-of-line whitespace.
[PATCH 2/4] Remove magic shebang SPACE.
[PATCH 3/4] Reuse variables. Copy/paste is less maintainable.
[PATCH 4/4] 'chmod' seems meaningless, as 'umask 022' guarantees
Cheers,
--
Cristian
From baf1acc39d2737a6727eaa80850bbb2b9f815599 Mon Sep 17 00:00:00 2001
From: Cristian Ionescu-Idbohrn <c...@axis.com>
Date: Wed, 4 Jan 2012 19:22:27 +0100
Subject: [PATCH 1/4] Remove end-of-line whitespace.
Signed-off-by: Cristian Ionescu-Idbohrn <c...@axis.com>
---
scanlogd | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scanlogd b/scanlogd
index 113fb65..cb38325 100755
--- a/scanlogd
+++ b/scanlogd
@@ -38,7 +38,7 @@ case "$1" in
;;
stop)
echo -n "Stopping $DESC: "
- start-stop-daemon --stop --oknodo --quiet --exec $DAEMON
+ start-stop-daemon --stop --oknodo --quiet --exec $DAEMON
echo "$NAME."
;;
restart|force-reload)
--
1.7.8.2
From cbbc53d4dc64bf9798c32d39c2a7b6f20e7721d8 Mon Sep 17 00:00:00 2001
From: Cristian Ionescu-Idbohrn <c...@axis.com>
Date: Wed, 4 Jan 2012 19:23:01 +0100
Subject: [PATCH 2/4] Remove magic shebang SPACE.
Signed-off-by: Cristian Ionescu-Idbohrn <c...@axis.com>
---
scanlogd | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scanlogd b/scanlogd
index cb38325..b2f0e30 100755
--- a/scanlogd
+++ b/scanlogd
@@ -1,4 +1,4 @@
-#! /bin/sh
+#!/bin/sh
### BEGIN INIT INFO
# Provides: scanlogd
# Required-Start: $remote_fs $syslog
--
1.7.8.2
From 1a8f597245c8575f55b945a55f29960bf50a8b0a Mon Sep 17 00:00:00 2001
From: Cristian Ionescu-Idbohrn <c...@axis.com>
Date: Wed, 4 Jan 2012 19:26:24 +0100
Subject: [PATCH 3/4] Reuse variables. Copy/paste is less maintainable.
Signed-off-by: Cristian Ionescu-Idbohrn <c...@axis.com>
---
scanlogd | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/scanlogd b/scanlogd
index b2f0e30..23c1bd8 100755
--- a/scanlogd
+++ b/scanlogd
@@ -16,18 +16,19 @@
# This file was automatically customized by dh-make on Sun, 19 Dec 1999 16:18:56 +0100
PATH=/usr/sbin:/sbin:/bin:/usr/bin
-DAEMON=/usr/sbin/scanlogd
NAME=scanlogd
-DESC=scanlogd
+DESC=$NAME
+DAEMON=/usr/sbin/$NAME
+RDIR=/var/run/$NAME
test -f $DAEMON || exit 0
set -e
umask 022
-if [ ! -d /var/run/scanlogd ]; then
- mkdir -p /var/run/scanlogd
- chmod 0755 /var/run/scanlogd
+if [ ! -d $RDIR ]; then
+ mkdir -p $RDIR
+ chmod 0755 $RDIR
fi
case "$1" in
--
1.7.8.2
From 96284bf75cf7b2a24dd08861de8ea3fc78de5169 Mon Sep 17 00:00:00 2001
From: Cristian Ionescu-Idbohrn <c...@axis.com>
Date: Wed, 4 Jan 2012 19:42:20 +0100
Subject: [PATCH 4/4] 'chmod' seems meaningless, as 'umask 022' guarantees
'0755'.
'chown' may be more meanigful, as that was what was done before.
Signed-off-by: Cristian Ionescu-Idbohrn <c...@axis.com>
---
scanlogd | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scanlogd b/scanlogd
index 23c1bd8..47e25eb 100755
--- a/scanlogd
+++ b/scanlogd
@@ -28,7 +28,7 @@ set -e
umask 022
if [ ! -d $RDIR ]; then
mkdir -p $RDIR
- chmod 0755 $RDIR
+ chown scanlogd:nogroup $RDIR
fi
case "$1" in
--
1.7.8.2
