Package: nanoblogger
Version: 3.2.3-2
Severity: normal
Tags: patch

Summary:
The tidy plugin shredders the feed files (*xml) if they (a) contain
non-ASCII characters and (b) are not encoded in UTF-8.

Details:
* blog.conf has a variable TIDY_ARGS
* tidy.sh has the following variables at the beginning:
  : ${TIDY_ARGS:=-asxhtml -n -utf8}
  : ${TIDY_HTML_ARGS:=$TIDY_ARGS}
  : ${TIDY_XML_ARGS:=-xml -n -utf8 -wrap 0}
* That means that the TIDY_XML_ARGS cannot be influenced via
  blog.conf at the moment, that '-utf8' is always used for the xml
  files, and that non-ASCII chars are scrambled if they are encoded
  differently than UTF-8 ...
  
Suggested solution:
* Delete the TIDY_ARGS variable from blog.conf and tidy.sh
* Set the defaults for TIDY_HTML_ARGS and TIDY_XML_ARGS in tidy.sh
* Add these two variables to blog.conf (with the default values in
  order to ease modifications for the user).

The suggested changes can be found in the patches below.

(This change would kind of break current installations, because
the existing TIDY_ARGS variable is not honoured any more. But IMO a
hint in the changelog and/or NEWS.Debian should be enough.)

gregor

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.4.31.20050730
Locale: LANG=C, [EMAIL PROTECTED] (charmap=ISO-8859-15)

-- no debconf information


*** tidy.sh.diff
--- plugins/makepage/tidy.sh.orig       2005-09-22 19:41:31.000000000 +0200
+++ plugins/makepage/tidy.sh    2005-09-22 19:43:27.000000000 +0200
@@ -19,4 +19,3 @@
 # set additional arguments
-: ${TIDY_ARGS:=-asxhtml -n -utf8}
-: ${TIDY_HTML_ARGS:=$TIDY_ARGS}
+: ${TIDY_HTML_ARGS:=-asxhtml -n -utf8}
 : ${TIDY_XML_ARGS:=-xml -n -utf8 -wrap 0}

*** blog.conf.diff
--- default/blog.conf.orig      2005-09-22 19:49:42.000000000 +0200
+++ default/blog.conf   2005-09-22 19:50:01.000000000 +0200
@@ -100,3 +100,5 @@
 # Tidy plugin - command arguments for tidy. see tidy's man pages or 
http://tidy.sourceforge.net/
-TIDY_ARGS=""
+# Values for HTML and XML files respectively.
+TIDY_HTML_ARGS="-asxhtml -n -utf8"
+TIDY_XML_ARGS="-xml -n -utf8 -wrap 0"
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to