package: pal
severity: serious
version: 0.4.3-7
tags: patch

Pal FTBFS in sid

make[2]: Entering directory 
`/build/buildd-pal_0.4.3-7-armhf-c4gnbL/pal-0.4.3/src'
Using CFLAGS: -Wall -g -O2
Using CPPFLAGS: -I/usr/include -I/usr/include/glib-2.0 
-I/usr/lib/arm-linux-gnueabihf/glib-2.0/include   -DPAL_VERSION="0.4.3" 
-DPREFIX="/usr" -DG_DISABLE_DEPRECATED -DDEBUG
Using LDFLAGS:  -lglib-2.0   -lreadline -lncursesw
[gcc debug] main.c
main.c:30:21: fatal error: ncurses.h: No such file or directory
compilation terminated.
make[2]: *** [tmp.debug/main.o] Error 1
make[2]: Leaving directory 
`/build/buildd-pal_0.4.3-7-armhf-c4gnbL/pal-0.4.3/src'
make[1]: *** [pal] Error 2
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

This was initially noticed on the armhf and s390x buildds but I have confirmed it also happens
on amd64.

It turns out that the package depends on and links against ncursesw but uses the headers from ncurses. This seems wrong to me but I don't know enough details about ncurses to know just how bad it is.

Previously the build succeeded because libncurses5-dev was pulled in indirectly but this is no
longer the case.

I have attatched an updated version of 51_debian_link_against_ncursesw.patch which changes the
header includes too.
pal (0.4.3-3)  * Link pal against libncursesw5 instead of libncurses5.
                 (Closes: #499403)

Index: pal-0.4.3.new/src/Makefile
===================================================================
--- pal-0.4.3.new.orig/src/Makefile	2008-07-28 16:16:23.000000000 +0000
+++ pal-0.4.3.new/src/Makefile	2011-12-11 22:55:32.000000000 +0000
@@ -4,7 +4,7 @@
 
 INCLDIR = -I${prefix}/include `pkg-config --cflags glib-2.0`
 LIBDIR  =
-LIBS    = `pkg-config --libs glib-2.0` -lreadline -lncurses
+LIBS    = `pkg-config --libs glib-2.0` -lreadline -lncursesw
 
 SRC     = main.c colorize.c output.c input.c event.c rl.c html.c latex.c \
           add.c edit.c del.c remind.c search.c manage.c
Index: pal-0.4.3.new/src/add.c
===================================================================
--- pal-0.4.3.new.orig/src/add.c	2008-07-28 16:16:23.000000000 +0000
+++ pal-0.4.3.new/src/add.c	2011-12-11 23:16:50.000000000 +0000
@@ -18,7 +18,7 @@
  *
  */
 
-#include <curses.h>
+#include <ncursesw/curses.h>
 
 #include "main.h"
 #include "output.h"
Index: pal-0.4.3.new/src/colorize.c
===================================================================
--- pal-0.4.3.new.orig/src/colorize.c	2011-12-11 23:13:43.000000000 +0000
+++ pal-0.4.3.new/src/colorize.c	2011-12-11 23:11:47.000000000 +0000
@@ -20,7 +20,7 @@
 
 #include <stdio.h>
 #include <stdlib.h> /* for getenv() */
-#include <curses.h>
+#include <ncursesw/curses.h>
 
 #include "main.h"
 #include "colorize.h"
Index: pal-0.4.3.new/src/del.c
===================================================================
--- pal-0.4.3.new.orig/src/del.c	2008-07-28 16:16:23.000000000 +0000
+++ pal-0.4.3.new/src/del.c	2011-12-11 23:17:44.000000000 +0000
@@ -19,7 +19,7 @@
  */
 
 #include <stdio.h>
-#include <ncurses.h>
+#include <ncursesw/ncurses.h>
 
 #include "main.h"
 #include "output.h"
Index: pal-0.4.3.new/src/edit.c
===================================================================
--- pal-0.4.3.new.orig/src/edit.c	2008-07-28 16:16:23.000000000 +0000
+++ pal-0.4.3.new/src/edit.c	2011-12-11 23:17:19.000000000 +0000
@@ -18,7 +18,7 @@
  *
  */
 
-#include <ncurses.h>
+#include <ncursesw/ncurses.h>
 
 #include "main.h"
 #include "output.h"
Index: pal-0.4.3.new/src/main.c
===================================================================
--- pal-0.4.3.new.orig/src/main.c	2011-12-11 22:55:32.000000000 +0000
+++ pal-0.4.3.new/src/main.c	2011-12-11 23:11:13.000000000 +0000
@@ -27,7 +27,7 @@
 #include <regex.h>     /* regular expressions */
 #include <glib.h>
 
-#include <ncurses.h>
+#include <ncursesw/ncurses.h>
 
 #include "output.h"
 #include "main.h"
Index: pal-0.4.3.new/src/manage.c
===================================================================
--- pal-0.4.3.new.orig/src/manage.c	2011-12-11 22:55:32.000000000 +0000
+++ pal-0.4.3.new/src/manage.c	2011-12-11 23:19:01.000000000 +0000
@@ -21,8 +21,8 @@
 #include "main.h"
 
 #include <readline/readline.h>
-#include <ncurses.h>
-#include <term.h>
+#include <ncursesw/ncurses.h>
+#include <ncursesw/term.h>
 #include <signal.h>
 #include <sys/ioctl.h> /* get # columns for terminal */
 
Index: pal-0.4.3.new/src/output.c
===================================================================
--- pal-0.4.3.new.orig/src/output.c	2008-07-28 16:16:23.000000000 +0000
+++ pal-0.4.3.new/src/output.c	2011-12-11 23:14:48.000000000 +0000
@@ -21,7 +21,7 @@
 #include <stdarg.h>
 #include <time.h>
 #include <string.h>
-#include <curses.h>
+#include <ncursesw/curses.h>
 
 /* for vsnprintf */
 #include <stdarg.h>
Index: pal-0.4.3.new/src/rl.c
===================================================================
--- pal-0.4.3.new.orig/src/rl.c	2011-12-11 22:55:32.000000000 +0000
+++ pal-0.4.3.new/src/rl.c	2011-12-11 23:16:23.000000000 +0000
@@ -21,10 +21,10 @@
 #include "main.h"
 
 #include <readline/readline.h>
-#include <ncurses.h>
+#include <ncursesw/ncurses.h>
 #include <time.h>
 
-#include <term.h>
+#include <ncursesw/term.h>
 
 
 #include "output.h"

Reply via email to