On Thu, 08 Dec 2011 22:51:14 -0400, Joey Hess wrote: > gregor herrmann wrote: > > I've prepared and tested a patch against current git now that > > implements removing of directories (i.e. '-rf') from the command line > > or via d/clean, if the compat level is at least 9. > I see dh_clean's lack of support for recursive removal a bit of a > feature.
I was afraid you would say that :) > It's a little unusual to need it, Right, and/but having to specify arguments do dh_clean is unusual in general in my experience; usually it means that upstream has forgotten to add something (a file or a directory), often created during tests, to their clean target, and we need to clean up after them. I've seen both files and directories in this category, and I don't see the big difference between these kinds of upstream laps. > and it's easy to put in a > manual rm -rf when it is needed. This ensures that recursive removal > is only done explicitly, which avoids it being done by accident. I see your points, and I agree that the workaround is not difficult, and that there's a certain risk. -- Still, I think the "-rf" feature would be more positive than negative. Maybe also because I'm used to 2-line d/rules file plus adding specific instructions in d/foo files, and having to write a manual "rm" into an override_dh_clean target just feels weird :) In any case, I'm happy to accept your decision; and thanks for considering this request. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key ID: 0x8649AA06 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe `- NP: Beatles
signature.asc
Description: Digital signature
