Hi Daniel,
thanks for your patch. Here are a few comments:
On Mon, Nov 21, 2011 at 04:41:58PM +0100, Daniel Dehennin wrote:
[..snip..]
> + if options.force_distribution:
> + dch_options += " --force-distribution"
> +
I really need to add a nicer way to pass dch options verbatim.
> get_customizations(options.customization_file)
> return dch_options
>
> @@ -348,6 +350,9 @@ def main(argv):
> help="mark as release")
> version_group.add_option("-S", "--snapshot", action="store_true",
> dest="snapshot", default=False,
> help="mark as snapshot build")
> + version_group.add_option("-D", "--distribution", dest="distribution",
> help="Use this as distribution")
> + version_group.add_option("--force-distribution", action="store_true",
> dest="force_distribution", default=False,
> + help="Force the provided distribution to be used, even
> if it doesn't match the list of known distributions")
> version_group.add_option("-N", "--new-version", dest="new_version",
> help="use this as base for the new version number")
> version_group.add_option("--bpo", dest="bpo", action="store_true",
> default=False,
> @@ -439,6 +444,15 @@ def main(argv):
> else:
> add_section = False
>
> + # Permit to change the distribution when ever we want
> + if options.distribution:
> + gbp.log.debug("Change distribution from {0} to
> {1}".format(cp['Distribution'],
> +
> options.distribution))
This doesn't match the string formatting we usually like format % (a,
b). Any reason for doing this differently here?
> + del(cp['Distribution'])
Is this necessary?
> + cp['Distribution'] = options.distribution
> + else:
> + options.distribution = "UNRELEASED"
Shouldn't the be handled via the options.distribution default falue?
Could you also rediff against the experimental branch please. The
sources got moved around quiet a bit so the patch wouldn't apply.
Cheers,
-- Guido
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
