Package: mandelbulber
Version: 1:1.08-1
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch oneiric

mandelbulber fails to build with a linker that defaults to --as-needed,
as shown in this Ubuntu build log:

  
https://launchpadlibrarian.net/84427668/buildlog_ubuntu-precise-i386.mandelbulber_1%3A1.08-1_FAILEDTOBUILD.txt.gz

This is because of incorrect link ordering: it puts libraries before the
objects that use them rather than after.  See:

  http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The following patch fixes this.

  * Fix link order to list libraries after the objects that require them.

diff -Nru mandelbulber-1.08/debian/patches/01_link-order 
mandelbulber-1.08/debian/patches/01_link-order
--- mandelbulber-1.08/debian/patches/01_link-order      1970-01-01 
01:00:00.000000000 +0100
+++ mandelbulber-1.08/debian/patches/01_link-order      2011-11-11 
14:12:37.000000000 +0000
@@ -0,0 +1,18 @@
+Description: List libraries after the objects that require them
+Author: Colin Watson <cjwat...@ubuntu.com>
+Forwarded: no
+Last-Update: 2011-11-11
+
+Index: b/makefiles/makefile
+===================================================================
+--- a/makefiles/makefile
++++ b/makefiles/makefile
+@@ -44,7 +44,7 @@
+ mandelbulber: $(OBJS) $(USER_OBJS)
+       @echo 'Building target: $@'
+       @echo 'Invoking: GCC C++ Linker'
+-      g++ `pkg-config --libs gtk+-2.0 gthread-2.0` -o"mandelbulber"$(OBJS) 
$(USER_OBJS) $(LIBS)
++      g++ -o"mandelbulber"$(OBJS) $(USER_OBJS) `pkg-config --libs gtk+-2.0 
gthread-2.0` $(LIBS)
+       @echo 'Finished building target: $@'
+       @echo ' '
+ 
diff -Nru mandelbulber-1.08/debian/patches/series 
mandelbulber-1.08/debian/patches/series
--- mandelbulber-1.08/debian/patches/series     2011-08-22 08:11:07.000000000 
+0100
+++ mandelbulber-1.08/debian/patches/series     2011-11-11 14:11:22.000000000 
+0000
@@ -1 +1,2 @@
 00_fix-desktop
+01_link-order

-- 
Colin Watson                                       [cjwat...@ubuntu.com]



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to