Bug#643448: nvramtool: FTBFS: hexdump.c:94:7: error: format not a string literal and no format arguments [-Werror=format-security]

[peter green]

Tags 643448 +patch
thanks

Patch is attatched just drop it in debian/patches (the package uses 
simple-patchsys so no series file is needed).


diff -Nur -x '*.orig' -x '*~' nvramtool-0.0+r3669/hexdump.c nvramtool-0.0+r3669.new/hexdump.c
--- nvramtool-0.0+r3669/hexdump.c	2008-09-27 10:08:28.000000000 +0000
+++ nvramtool-0.0+r3669.new/hexdump.c	2011-11-10 01:39:12.000000000 +0000
@@ -91,9 +91,9 @@
         bytes_left >= format->bytes_per_line;
         bytes_left -= format->bytes_per_line)
     { /* print start address for current line */
-      fprintf(outfile, format->indent);
+      fprintf(outfile, "%s",format->indent);
       addrprint(outfile, addrprint_start + index, format->addrprint_width);
-      fprintf(outfile, format->sep1);
+      fprintf(outfile, "%s",format->sep1);
 
       /* display the bytes in hex */
       for (i = 0; ; )
@@ -102,11 +102,11 @@
          if (++i >= format->bytes_per_line)
             break;
 
-         fprintf(outfile, format->sep2);
+         fprintf(outfile,"%s", format->sep2);
        }
 
       index -= format->bytes_per_line;
-      fprintf(outfile, format->sep3);
+      fprintf(outfile,"%s", format->sep3);
 
       /* display the bytes as characters */
       for (i = 0; i < format->bytes_per_line; i++)
@@ -120,14 +120,14 @@
       return;
 
    /* print start address for last line */
-   fprintf(outfile, format->indent);
+   fprintf(outfile,"%s", format->indent);
    addrprint(outfile, addrprint_start + index, format->addrprint_width);
-   fprintf(outfile, format->sep1);
+   fprintf(outfile, "%s",format->sep1);
 
    /* display bytes for last line in hex */
    for (i = 0; i < bytes_left; i++)
     { hexprint(outfile, p[index++]);
-      fprintf(outfile, format->sep2);
+      fprintf(outfile, "%s",format->sep2);
     }
 
    index -= bytes_left;
@@ -139,10 +139,10 @@
       if (++i >= format->bytes_per_line)
          break;
 
-      fprintf(outfile, format->sep2);
+      fprintf(outfile,"%s", format->sep2);
     }
 
-   fprintf(outfile, format->sep3);
+   fprintf(outfile, "%s",format->sep3);
 
    /* display bytes for last line as characters */
    for (i = 0; i < bytes_left; i++)