Le samedi, 5 novembre 2011 12.49:34, Stefan Potyra a écrit : > On Thu, Nov 03, 2011 at 06:10:13PM +0100, Didier Raboud wrote: > > In order to have a consistent naming across printer driver packages, > > please rename min12xxw to printer-driver-min12xxw. > > > > A debdiff of the proposed renaming is attached. > > Seems like there are some pieces missing in the debdiff. I see only a > changelog and changes to aclocal.m4 (the latter shouldn't be present at > all).
Indeed, I messed up the debdiff. Meh. > I've done the renaming in svn now, but as the package needs to go through > binary new, I need a sponsor. Care to take a look? > > dget > http://mentors.debian.net/debian/pool/main/m/min12xxw/min12xxw_0.0.9-6.dsc I'd be happy to. But this should be fixed IMHO: * From lintian: direct-changes-in-diff-but-no-patch-system Makefile.am and min12xxw.c. Changes to those files are un-documented. You should really use a proper patch system as this greatly helps documenting the reasons and justifications behind the changes. From an outsider point of view (not reading the svn log), all what this person gets is: http://patch- tracker.debian.org/package/min12xxw/0.0.9-5 * Lintian warning: W: min12xxw source: debhelper-but-no-misc-depends min12xxw Indeed, you need to add ${misc:Depends} to min12xxw's Depennds field. * The homepage information is in the description, where it should only be in its own "Homepage:" field in the source section of debian/control. * From the changelog: "debian/rules: change synopsis to start with a lower case letter" : the synopsis is not in debian/rules but in debian/control, right? * From lintian: copyright-refers-to-symlink-license usr/share/common- licenses/GPL (you should point to GPL-2) And I think that's all for now. :-> > > By the way, I would like to kindly propose you (again, right ?) to put > > min12xxw under the Debian Printing Team umbrella, to help with eventual > > future discussions and sharing the maintainance load. (This does _not_ > > mean other persons take over maintaince, it means that we collectively > > try to take a look at the "big picture".) > > Thanks for the offer, however I'd like to keep it the way it is now. > > Please note that the package lives in collab-maint and I'm listed on > LowThresholdNmu, so the means are already in place that changes like the > proposed one can be done by the printing team or anyone else in a > straightforward manner. No problem. Note though that all the printing team packages _are_ under collab-maint, which doesn't necessarily mean that anyone can touch them without coordination. And see e.g. how the same change got proposed to c2050's maintainer [0] (aka: almost exactly as was done for min12xxw). [0] http://lists.debian.org/debian-printing/2011/10/msg00043.html Cheers, -- OdyX
signature.asc
Description: This is a digitally signed message part.
