Package: yajl
Version: 1.0.12-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

There's a missing backslash at the end of a line in debian/rules which
has the effect that -DCMAKE_VERBOSE_MAKEFILE=ON is lost.  Could you
restore this?  It makes build logs more useful.

(Also, it would be nice to use the default build flags from
dpkg-buildflags.  I've included that in my patch in case it helps.)

  * Restore -DCMAKE_VERBOSE_MAKEFILE=ON.
  * Export the output from dpkg-buildflags.

diff -Nru yajl-1.0.12/debian/control yajl-1.0.12/debian/control
--- yajl-1.0.12/debian/control  2011-07-18 21:41:32.000000000 -0400
+++ yajl-1.0.12/debian/control  2011-11-02 15:15:44.000000000 -0400
@@ -2,7 +2,7 @@
 Section: libs
 Priority: extra
 Maintainer: John Stamp <jst...@users.sourceforge.net>
-Build-Depends: debhelper (>= 8.1.3), cmake, doxygen
+Build-Depends: dpkg-dev (>= 1.16.1~), debhelper (>= 8.1.3), cmake, doxygen
 Standards-Version: 3.9.2
 Homepage: http://lloyd.github.com/yajl/
 Vcs-Browser: http://github.com/jstamp/yajl
diff -Nru yajl-1.0.12/debian/rules yajl-1.0.12/debian/rules
--- yajl-1.0.12/debian/rules    2011-07-18 21:41:32.000000000 -0400
+++ yajl-1.0.12/debian/rules    2011-11-02 15:09:24.000000000 -0400
@@ -13,6 +13,9 @@
 # This has to be exported to make some magic below work.
 export DH_OPTIONS
 
+DPKG_EXPORT_BUILDFLAGS := 1
+include /usr/share/dpkg/buildflags.mk
+
 
 configure: config-stamp
 config-stamp:
@@ -21,7 +24,7 @@
        cd build && cmake .. -DCMAKE_INSTALL_PREFIX=/usr \
                -DCMAKE_BUILD_TYPE=RelWithDebInfo \
                -DCMAKE_SKIP_RPATH=ON \
-               -DMULTIARCH_TUPLE=`dpkg-architecture -qDEB_HOST_MULTIARCH`
+               -DMULTIARCH_TUPLE=`dpkg-architecture -qDEB_HOST_MULTIARCH` \
                -DCMAKE_VERBOSE_MAKEFILE=ON
        touch $@
 

Thanks,

-- 
Colin Watson                                       [cjwat...@ubuntu.com]



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to